Skip to content

Commit 78872c5

Browse files
committed
fixed key error in getting default storage class
Signed-off-by: Katharina Trentau <[email protected]>
1 parent f9436e5 commit 78872c5

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

Tests/kaas/k8s-default-storage-class/k8s-default-storage-class-check.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,7 @@ def check_default_storageclass(k8s_client_storage):
6060
for item in storageclasses_dict["items"]:
6161
storage_class_name = item["metadata"]["name"]
6262
annotations = item["metadata"]["annotations"]
63-
64-
if annotations["storageclass.kubernetes.io/is-default-class"] == "true":
63+
if annotations.get("storageclass.kubernetes.io/is-default-class") == "true":
6564
ndefault_class += 1
6665
default_storage_class = storage_class_name
6766
provisioner = item["provisioner"]
@@ -225,6 +224,7 @@ def __init__(self, kubeconfig):
225224
self.return_code = 0
226225
self.return_message = "return_message: FAILED"
227226
self.kubeconfig = kubeconfig
227+
self.cleanup = False
228228

229229
def prepare(self):
230230
"""
@@ -297,7 +297,9 @@ def __enter__(self):
297297
return self
298298

299299
def __exit__(self, exc_type, exc_value, traceback):
300-
self.clean()
300+
logger.debug("exiting")
301+
if self.cleanup:
302+
self.clean()
301303
if self.return_code == 0:
302304
self.return_message = "all tests passed"
303305
if isinstance(exc_value, SCSTestException):
@@ -356,7 +358,7 @@ def main(argv):
356358
env.return_code = 1
357359
logger.debug("check_default_storageclass() failed")
358360
return env.return_code
359-
361+
env.cleanup = True
360362
try:
361363
env.return_code = create_pvc_pod(k8s_core_api, default_class_name)
362364
except ApiException as api_exception:

0 commit comments

Comments
 (0)