Skip to content

Commit 8c06055

Browse files
committed
Relax wording to reflect weaknesses in the test for scs-0214-v2
Signed-off-by: Matthias Büchse <[email protected]>
1 parent e827574 commit 8c06055

File tree

3 files changed

+9
-25
lines changed

3 files changed

+9
-25
lines changed

Standards/scs-0214-v2-k8s-node-distribution.md

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -101,15 +101,6 @@ These labels MUST be kept up to date with the current state of the deployment.
101101
The field gets autopopulated most of the time by either the kubelet or external mechanisms
102102
like the cloud controller.
103103

104-
## Conformance Tests
105-
106-
The script `k8s-node-distribution-check.py` checks the nodes available with a user-provided
107-
kubeconfig file. Based on the labels
108-
`topology.kubernetes.io/zone`, `topology.kubernetes.io/region` and `node-role.kubernetes.io/control-plane`,
109-
the script then determines whether the nodes are distributed according to this standard.
110-
If this isn't the case, the script produces an error.
111-
It also produces warnings and informational outputs, e.g., if labels don't seem to be set.
112-
113104
## Previous standard versions
114105

115106
This is version 2 of the standard; it extends [version 1](scs-0214-v1-k8s-node-distribution.md) with the

Standards/scs-0214-w1-k8s-node-distribution-implementation-testing.md

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,11 @@ Node distribution metadata is provided through the usage of the labels
2020

2121
## Automated tests
2222

23-
### Notes
23+
Currently, automated testing is not readily possible because we cannot access information about
24+
the underlying host of a node (as opposed to its region and zone). Therefore, the test will only output
25+
a tentative result.
2426

25-
The test for the [SCS K8s Node Distribution and Availability](https://github.com/SovereignCloudStack/standards/blob/main/Standards/scs-0214-v2-k8s-node-distribution.md)
26-
checks if control-plane nodes are distributed over different failure zones (distributed into
27-
physical machines, zones and regions) by observing their labels defined by the standard.
28-
29-
### Implementation
30-
31-
The script [`k8s_node_distribution_check.py`](https://github.com/SovereignCloudStack/standards/blob/main/Tests/kaas/k8s-node-distribution/k8s_node_distribution_check.py)
32-
connects to an existing K8s cluster and checks if a distribution can be detected with the labels
33-
set for the nodes of this cluster.
27+
The current implementation can be found in the script [`k8s_node_distribution_check.py`](https://github.com/SovereignCloudStack/standards/blob/main/Tests/kaas/k8s-node-distribution/k8s_node_distribution_check.py).
3428

3529
## Manual tests
3630

Tests/kaas/k8s-node-distribution/k8s_node_distribution_check.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -162,12 +162,11 @@ def compare_labels(node_list, node_type="control"):
162162
)
163163
return
164164

165-
if node_type == "control":
166-
raise DistributionException("The distribution of nodes described in the standard couldn't be detected.")
167-
elif node_type == "worker":
168-
logger.warning("No node distribution could be detected for the worker nodes. "
169-
"This produces only a warning, since it is just a recommendation.")
170-
return
165+
#
166+
# if node_type == "control":
167+
# raise DistributionException("The distribution of nodes described in the standard couldn't be detected.")
168+
logger.warning("No node distribution could be detected for the worker nodes. "
169+
"This produces only a warning, since it is just a recommendation.")
171170

172171

173172
def check_nodes(nodes):

0 commit comments

Comments
 (0)