Skip to content

Commit 9cc2d6d

Browse files
markus-hentschgtema
authored andcommitted
Address review comments
Signed-off-by: Markus Hentsch <[email protected]>
1 parent 23f353a commit 9cc2d6d

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

Standards/scs-0302-v1-domain-manager-role.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ This means that by creating a new role and extending Keystone's API policy confi
9898

9999
A role named "`manager`" MUST be present in the identity service.
100100

101-
The role MUST implement the Domain Manager functionality for identity resources.
101+
The identity service MUST implement the Domain Manager functionality for this role.
102102
The implementation details depend on the OpenStack Keystone version used.
103103
See the sections below for reference.
104104

@@ -120,7 +120,8 @@ When doing so, the `admin` role MUST NOT be added to this set.
120120

121121
#### Note about upgrading from SCS Domain Manager to native integration
122122

123-
In case the Identity API was upgraded from an older version where the policy-based Domain Manager implementation of SCS described in the [implementation notes for this standard](https://github.com/SovereignCloudStack/standards/blob/main/Standards/scs-0302-w1-domain-manager-implementation-notes.md) was still in use, the policies described there MUST be removed (except for the "`is_domain_managed_role`" rule).
123+
In case the Identity API was upgraded from an older version where the policy-based Domain Manager implementation of SCS described in the [implementation notes for this standard](https://github.com/SovereignCloudStack/standards/blob/main/Standards/scs-0302-w1-domain-manager-implementation-notes.md) was still in use, the policies described there MUST be removed.
124+
The only exception to this is the "`is_domain_managed_role`" rule in case any adjustments have been made to that rule and the CSP wants to preserve them.
124125

125126
### For OpenStack Keystone 2024.1 or below
126127

0 commit comments

Comments
 (0)