Cleanup: Use Property.check() directly.

Also (from last commit):
Allow 32MiB min_ram images, as this is the default min for Cirros.

Signed-off-by: Kurt Garloff <[email protected]>

Author: garloff

Tests/iaas/image-metadata/image-md-check.py

@@ -111,7 +111,7 @@ def check(self, props, warn):
             # Property empty => WARN (or ERROR if no allowed value list)
             if (verbose or not self.values) and warn:
                 errstr = "WARNING" if ok else "ERROR"
-                print(f'{errstr}: Image "{warn}": empty value for property "{self.name}" not recommended',
+                print(f'{errstr}: Image "{warn}": empty value for property "{self.name}" not good',
                       file=sys.stderr)
             return (ok, not ok)
         # Property does not exist but is mandatory => ERROR
@@ -130,11 +130,6 @@ def is_ok(self, props, warn = ""):
         ok, nowarn = self.check(props, warn)
         return ok
 
-    def is_nowarn(self, props, warn = ""):
-        "Return True if nothing to warn about is found"
-        ok, nowarn = self.check(props, warn)
-        return nowarn
-
 
 # From the image metadata specification
 # https://github.com/SovereignCloudStack/Docs/blob/main/Design-Docs/Image-Properties-Spec.md
@@ -226,9 +221,10 @@ def validate_imageMD(img, outd_list):
     # (4) image_build_date, image_original_user, image_source (opt image_description)
     # (5) maintained_until, provided_until, uuid_validity, replace_frequency
     for prop in (*os_props, *arch_props, *hw_props):
-        if not prop.is_ok(img, imgnm):
+        ok, nowarn = prop.check(img, imgnm)
+        if not ok:
             errors += 1
-        elif not prop.is_nowarn(img, ""):
+        elif not nowarn:
             warnings += 1
     # We do not count missing optional fields in these
     for prop in (*build_props, *maint_props):