Skip to content

Commit d43a38d

Browse files
committed
Update 'kind_plugin.py' kubeconfig filepath handling
Signed-off-by: Toni Finger <[email protected]>
1 parent cfa113c commit d43a38d

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

Tests/kaas/plugin/plugin_kind.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import shutil
21
import os
32
import os.path
3+
from pathlib import Path
44
from interface import KubernetesClusterPlugin
55
from pytest_kind import KindCluster
66
import logging
@@ -19,7 +19,7 @@ def __init__(self, config_file=None):
1919
self.working_directory = os.getcwd()
2020
logger.debug(f"Working from {self.working_directory}")
2121

22-
def create_cluster(self, cluster_name="scs-cluster", version=None, kubeconfig_filepath=None):
22+
def create_cluster(self, cluster_name="scs-cluster", version=None, kubeconfig=None):
2323
"""
2424
This method is to be called to create a k8s cluster
2525
:param: kubernetes_version:
@@ -33,17 +33,16 @@ def create_cluster(self, cluster_name="scs-cluster", version=None, kubeconfig_fi
3333
elif cluster_version == '1.31' or cluster_version == 'default':
3434
cluster_version = 'v1.31.1'
3535
cluster_image = f"kindest/node:{cluster_version}"
36-
self.cluster = KindCluster(name=cluster_name, image=cluster_image)
36+
kubeconfig_filepath = Path(kubeconfig)
37+
if kubeconfig_filepath is None:
38+
raise ValueError("kubeconfig_filepath is missing")
39+
else:
40+
self.cluster = KindCluster(name=cluster_name, image=cluster_image, kubeconfig=kubeconfig_filepath)
3741
if self.config is None:
3842
self.cluster.create()
3943
else:
4044
self.cluster.create(self.config)
41-
self.kubeconfig = str(self.cluster.kubeconfig_path.resolve())
42-
if kubeconfig_filepath:
43-
shutil.move(self.kubeconfig, kubeconfig_filepath)
44-
else:
45-
kubeconfig_filepath = str(self.kubeconfig)
46-
return kubeconfig_filepath
45+
return str(self.cluster.kubeconfig_path.resolve())
4746

4847
def delete_cluster(self, cluster_name=None):
4948
self.cluster = KindCluster(cluster_name)

0 commit comments

Comments
 (0)