Skip to content

Commit 03d3398

Browse files
committed
New ruff rule on main
1 parent 580ecd5 commit 03d3398

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

python/tests/test_wrapper_coverage.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import datafusion.functions
2020
import datafusion.object_store
2121
import datafusion.substrait
22+
import pytest
2223

2324
# EnumType introduced in 3.11. 3.10 and prior it was called EnumMeta.
2425
try:
@@ -45,10 +46,6 @@ def missing_exports(internal_obj, wrapped_obj) -> None:
4546
return
4647

4748
for internal_attr_name in dir(internal_obj):
48-
# Skip internal implementation details that shouldn't be exposed in public API
49-
if internal_attr_name in ["_global_ctx"]:
50-
continue
51-
5249
wrapped_attr_name = (
5350
internal_attr_name[3:]
5451
if internal_attr_name.startswith("Raw")
@@ -65,8 +62,7 @@ def missing_exports(internal_obj, wrapped_obj) -> None:
6562
# object they must also exist on the wrapped object.
6663
if internal_attr is not None:
6764
if wrapped_attr is None:
68-
print("Missing attribute: ", internal_attr_name)
69-
assert False
65+
pytest.fail(f"Missing attribute: {internal_attr_name}")
7066

7167
if internal_attr_name in ["__self__", "__class__"]:
7268
continue

0 commit comments

Comments
 (0)