Enabled ruff rule FBT003

Author: Spaarsh

benchmarks/db-benchmark/groupby-datafusion.py

@@ -93,8 +93,8 @@ def execute(df) -> list:
 )
 config = (
     SessionConfig()
-    .with_repartition_joins(False)
-    .with_repartition_aggregations(False)
+    .with_repartition_joins(enabled=False)
+    .with_repartition_aggregations(enabled=False)
     .set("datafusion.execution.coalesce_batches", "false")
 )
 ctx = SessionContext(config, runtime)

examples/create-context.py

@@ -25,14 +25,14 @@
 runtime = RuntimeEnvBuilder().with_disk_manager_os().with_fair_spill_pool(10000000)
 config = (
     SessionConfig()
-    .with_create_default_catalog_and_schema(True)
+    .with_create_default_catalog_and_schema(enabled=True)
     .with_default_catalog_and_schema("foo", "bar")
     .with_target_partitions(8)
-    .with_information_schema(True)
-    .with_repartition_joins(False)
-    .with_repartition_aggregations(False)
-    .with_repartition_windows(False)
-    .with_parquet_pruning(False)
+    .with_information_schema(enabled=True)
+    .with_repartition_joins(enabled=False)
+    .with_repartition_aggregations(enabled=False)
+    .with_repartition_windows(enabled=False)
+    .with_parquet_pruning(enabled=False)
     .set("datafusion.execution.parquet.pushdown_filters", "true")
 )
 ctx = SessionContext(config, runtime)

examples/tpch/q08_market_share.py

@@ -150,7 +150,7 @@
 df = df.with_column(
     "national_volume",
     F.case(col("s_suppkey").is_null())
-    .when(lit(False), col("volume"))
+    .when(lit(value=False), col("volume"))
     .otherwise(lit(0.0)),
 )
 

examples/tpch/q21_suppliers_kept_orders_waiting.py

@@ -65,7 +65,7 @@
 df = df.with_column(
     "failed_supp",
     F.case(col("l_receiptdate") > col("l_commitdate"))
-    .when(lit(True), col("l_suppkey"))
+    .when(lit(value=True), col("l_suppkey"))
     .end(),
 )
 

pyproject.toml

@@ -92,7 +92,7 @@ ignore = [
     # "B904",
     # "UP006",
     # "RUF012",
-    "FBT003",
+    # "FBT003",
     "C416",
     "SIM102",
     "PGH003",

python/datafusion/expr.py

@@ -176,7 +176,7 @@ def sort_or_default(e: Expr | SortExpr) -> expr_internal.SortExpr:
     """Helper function to return a default Sort if an Expr is provided."""
     if isinstance(e, SortExpr):
         return e.raw_sort
-    return SortExpr(e, True, True).raw_sort
+    return SortExpr(e, ascending=True, nulls_first=True).raw_sort
 
 
 def sort_list_to_raw_sort_list(

python/tests/test_functions.py

@@ -81,7 +81,7 @@ def test_literal(df):
         literal("1"),
         literal("OK"),
         literal(3.14),
-        literal(True),
+        literal(value=True),
         literal(b"hello world"),
     )
     result = df.collect()