Skip to content

Commit 5b41959

Browse files
committed
implemented reviews
1 parent 05ff09e commit 5b41959

File tree

3 files changed

+2
-26
lines changed

3 files changed

+2
-26
lines changed

examples/python-udf-comparisons.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,7 @@ def udf_using_pyarrow_compute_impl(
162162
resultant_arr = pc.and_(filtered_partkey_arr, filtered_suppkey_arr)
163163
resultant_arr = pc.and_(resultant_arr, filtered_returnflag_arr)
164164

165-
if results is None:
166-
results = (
167-
resultant_arr if results is None else pc.or_(results, resultant_arr)
168-
)
165+
results = resultant_arr if results is None else pc.or_(results, resultant_arr)
169166

170167
return results
171168

pyproject.toml

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -80,29 +80,11 @@ ignore = [
8080
"TD003", # Allow TODO lines
8181
"UP007", # Disallowing Union is pedantic
8282
# TODO: Enable all of the following, but this PR is getting too large already
83-
#"PT001",
84-
# "ANN204",
85-
# "B008",
86-
# "EM101",
8783
"PLR0913",
88-
# "PLR1714",
89-
# "ANN201",
90-
# "C400",
9184
"TRY003",
92-
# "B904",
93-
# "UP006",
94-
# "RUF012",
95-
# "FBT003",
96-
# "C416",
97-
# "SIM102",
98-
# "PGH003",
9985
"PLR2004",
100-
# "PERF401",
10186
"PD901",
102-
# "EM102",
10387
"ERA001",
104-
# "SIM108",
105-
# "ICN001",
10688
"ANN001",
10789
"ANN202",
10890
"PTH",

python/datafusion/context.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -841,10 +841,7 @@ def register_csv(
841841
selected for data input.
842842
file_compression_type: File compression type.
843843
"""
844-
if isinstance(path, list):
845-
path = [str(p) for p in path] if isinstance(path, list) else str(path)
846-
else:
847-
path = str(path)
844+
path = [str(p) for p in path] if isinstance(path, list) else str(path)
848845

849846
self.ctx.register_csv(
850847
name,

0 commit comments

Comments
 (0)