Skip to content

Commit 42e46f3

Browse files
authored
Add support for python 3.8 (#1)
* Add support for python 3.8 * Pin version of cspell and only check modified files
1 parent 5307320 commit 42e46f3

File tree

4 files changed

+23
-14
lines changed

4 files changed

+23
-14
lines changed

.github/workflows/CI.yml

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,16 @@ jobs:
2020

2121
- name: Install spellchecker
2222
run: |
23-
npm install -g cspell@latest
23+
npm install -g [email protected]
24+
- uses: tj-actions/changed-files@ed68ef82c095e0d48ec87eccea555d944a631a4c # v46
25+
id: changed-files
26+
with:
27+
separator: ","
2428
- name: Run spellchecker
2529
run: |
26-
cspell --config cspell.json --color --show-suggestions '**'
30+
# Run spellchecker with changed files
31+
mapfile -d ',' -t added_modified_files < <(printf '%s,' '${{ steps.changed-files.outputs.all_changed_and_modified_files }}')
32+
cspell --config cspell.json --color --show-suggestions "${added_modified_files[@]}"
2733
2834
- name: Install python tools
2935
run: |
@@ -38,7 +44,7 @@ jobs:
3844
bandit -c pyproject.toml -r .
3945
4046
docker:
41-
needs:
47+
needs:
4248
- pre-checks
4349
runs-on: ubuntu-22.04
4450
permissions:
@@ -48,12 +54,13 @@ jobs:
4854
strategy:
4955
fail-fast: false
5056
matrix:
51-
image:
57+
image:
58+
- 3.8-bookworm
5259
- 3.9-bookworm
5360
- 3.10-bookworm
5461
- 3.11-bookworm
5562
- 3.12-bookworm
56-
- 3.13-bookworm
63+
- 3.13-bookworm
5764
steps:
5865
- uses: actions/checkout@v4
5966
with:
@@ -88,11 +95,11 @@ jobs:
8895
# Create the tag and print the output. Do not push.
8996
git tag -a -m "$LOGGING_PIPELINE_VERSION ($(date -I))" $LOGGING_PIPELINE_VERSION
9097
git tag --list -n "$LOGGING_PIPELINE_VERSION"
91-
98+
9299
- name: Install dependencies
93100
run: |
94101
pip install build twine ruff bandit
95-
102+
96103
- name: Build package
97104
run: |
98105
python -m build
@@ -108,7 +115,7 @@ jobs:
108115
- name: Generate release notes
109116
run: |
110117
sed -n "/## $(sed -n '/^## / { s/^## //; p; }' CHANGELOG.md | head -n 1)/, /## / { /## /! p; }" CHANGELOG.md > RELEASE_NOTES.md
111-
118+
112119
- name: Upload distribution
113120
if: ${{ env.DO_RELEASE == 'true' }}
114121
uses: actions/upload-artifact@v4

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11

22
# Changelog
33

4+
## 0.3.0
5+
6+
- Add support for python 3.7 and 3.8.
7+
48
## 0.2.0
59

610
- Fix redirection in test where a file `nul` was created in working directory.

cspell.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
"levelname",
1717
"levelno",
1818
"logissue",
19+
"mapfile",
1920
"pycache",
2021
"PYPI",
2122
"pyproject",

pyproject.toml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
[build-system]
33
requires = [
4-
"hatchling==1.26.1",
4+
"hatchling~=1.27.0",
55
"hatch-autorun",
66
"hatch-vcs==0.4.0",
77
"hatch-fancy-pypi-readme==24.1.0"
@@ -22,20 +22,17 @@ authors = [
2222
{ name="Michael Förderer", email="[email protected]" },
2323
]
2424
description = "Inject logging handler for printing message in the format captured by pipeline"
25-
requires-python = ">=3.9"
25+
requires-python = ">=3.8"
2626
classifiers = [
2727
"Development Status :: 3 - Alpha",
2828
"Environment :: Console",
2929
"Intended Audience :: Developers",
3030
"Intended Audience :: Science/Research",
3131
"License :: OSI Approved :: BSD License",
3232
"Natural Language :: English",
33-
"Operating System :: MacOS :: MacOS X",
34-
"Operating System :: Microsoft :: Windows",
35-
"Operating System :: POSIX",
36-
"Operating System :: Unix",
3733
"Programming Language :: Python",
3834
"Programming Language :: Python :: 3",
35+
"Programming Language :: Python :: 3.8",
3936
"Programming Language :: Python :: 3.9",
4037
"Programming Language :: Python :: 3.10",
4138
"Programming Language :: Python :: 3.11",

0 commit comments

Comments
 (0)