Use TextAlertPopup instead of geode::Notification and other stuff

Author: SpaghettDev

.github/ISSUE_TEMPLATE/report-bug.yml

@@ -32,6 +32,7 @@ body:
         - 2.0.0
         - 2.0.1
         - 2.0.2
+        - 2.0.3
     validations:
       required: true
   - type: dropdown

.github/ISSUE_TEMPLATE/suggest-feature.yml

@@ -0,0 +1,17 @@
+name: Feature Suggestion
+description: Suggest a feature
+title: "[Feature]: "
+labels: ["enhancement"]
+projects: "SpaghettDev/4"
+assignees:
+  - SpaghettDev
+body:
+  - type: textarea
+    id: feature-text
+    attributes:
+      label: What is your suggested feature?
+      description: Provide a detailed explanation of what you would want to see added to this project.
+      placeholder: Tell us what you want!
+      value: "I would like ..."
+    validations:
+      required: true

ABOUT.md

@@ -26,3 +26,7 @@ You can currently select 1 of 4 options: Normal List, Demon List, Challenge List
 Info about these lists can be found by clicking the corresponding info icon next to the list's button.
 
 And that's pretty much it! Have fun rouletting!
+
+## Contact
+
+You can contact me through my personal [Discord server](https://discord.gg/WPcqK3Yt).

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [2.0.3] - 2024-03-09
+
+### Changed
+
+- No longer use `geode::Notification`, now use `rl::utils::createNotificationToast`
+
 ## [2.0.2] - 2024-03-06
 
 ### Added

README.md

@@ -37,6 +37,10 @@ Then open the generated solution in Visual Studio.
 
 **Make sure to compile in Release Mode! Otherwise the solution will not compile.**
 
+## Contact
+
+You can contact me through my personal [Discord server](https://discord.gg/WPcqK3Yt) to get instant™️ support and other stuff ig.
+
 ## Credits
 
 - SpaghettDev ([@SpaghettDev](https://github.com/SpaghettDev)): Creator & maintainer.

mod.json

@@ -5,7 +5,7 @@
 		"android": "2.205",
 		"mac": "2.200"
 	},
-	"version": "v2.0.2",
+	"version": "v2.0.3",
 	"id": "spaghettdev.gd-roulette",
 	"name": "GD-Roulette",
 	"developer": "SpaghettDev",

src/layers/LevelInfoLayer.cpp

@@ -8,8 +8,6 @@
 
 using namespace geode::prelude;
 
-std::list<int> levelIDs{};
-
 class $modify(LevelInfoLayer)
 {
 	bool init(GJGameLevel* level, bool p1)
@@ -18,12 +16,9 @@ class $modify(LevelInfoLayer)
 
 		if (g_rouletteManager.isPlaying && level->m_levelID.value() == g_rouletteManager.currentLevelID)
 		{
-			levelIDs.push_back(level->m_levelID);
-
 			CCLabelBMFont* normalPercentageLabel = static_cast<CCLabelBMFont*>(this->getChildByID("normal-mode-percentage"));
 			float goalOffset = .0f;
 
-			// TODO: fix this because it only happens on platformer levels, which only happens in GD List
 			if (!normalPercentageLabel) return true;
 
 			// wtf v2
@@ -51,18 +46,14 @@ class $modify(LevelInfoLayer)
 
 	void onBack(CCObject* sender)
 	{
-		if (g_rouletteManager.isPlaying)
-		{
-			if (levelIDs.size() != 0)
-				levelIDs.pop_back();
-
-			if (g_rouletteManager.rouletteLayer && levelIDs.back() == g_rouletteManager.currentLevelID)
-			{
-				static_cast<CCLabelBMFont*>(
-					g_rouletteManager.rouletteLayer->playing_menu->getChildByID("percentage-text")
-				)->setString(fmt::format("{}%", g_rouletteManager.levelPercentageGoal).c_str());
-			}
-		}
+		if (
+			g_rouletteManager.isPlaying &&
+			g_rouletteManager.rouletteLayer &&
+			this->m_level->m_levelID.value() == g_rouletteManager.currentLevelID
+		)
+			static_cast<CCLabelBMFont*>(
+				g_rouletteManager.rouletteLayer->playing_menu->getChildByID("percentage-text")
+			)->setString(fmt::format("{}%", g_rouletteManager.levelPercentageGoal).c_str());
 
 		LevelInfoLayer::onBack(sender);
 	}

src/layers/PauseLayer.cpp

@@ -19,7 +19,6 @@ class $modify(PauseLayer)
 			CCLabelBMFont* normalPercentageLabel = static_cast<CCLabelBMFont*>(this->getChildByID("normal-progress-label"));
 			float goalOffset = 24.f;
 
-			// TODO: fix this because it only happens on platformer levels, which only happens in GD List
 			if (!normalPercentageLabel) return;
 
 			if (playLayer->m_level->m_normalPercent < 10)

src/roulette/layers/RLRouletteLayer.cpp

@@ -6,6 +6,7 @@
 #include "RLRouletteInfoLayer.hpp"
 #include "../manager/RouletteManager.hpp"
 #include "../../custom_nodes/RLDifficultyNode.hpp"
+#include "../../custom_layers/RLDifficultySelectLayer.hpp"
 #include "../../utils.hpp"
 
 #include <Geode/Geode.hpp>
@@ -386,8 +387,7 @@ void RLRouletteLayer::onInfoButton(CCObject*)
 			m_roulette_info_layer->show();
 	}
 	else
-		// this->addChild(TextAlertPopup::create("You are currently in a game of roulette!", 1.2f, .8f, 1, "bigFont.fnt"));
-		Notification::create("You are currently in a game of roulette!", NotificationIcon::Error, .7f)->show();
+		rl::utils::createNotificationToast(this, "You are currently in a game of roulette!", .5f, 85.f);
 }
 
 void RLRouletteLayer::onDifficultyButton(CCObject* sender)
@@ -475,8 +475,7 @@ void RLRouletteLayer::onLevelInfo(CCObject* sender)
 	}
 
 	clipboard::write(text);
-	// this->addChild(TextAlertPopup::create("Copied to Clipboard", .5f, .6f, 1, "bigFont.fnt"));
-	Notification::create("Copied to Clipboard", NotificationIcon::Success)->show();
+	rl::utils::createNotificationToast(this, "Copied to Clipboard", .5f, 85.f);
 }
 
 void RLRouletteLayer::onPlayButton(CCObject*)
@@ -535,16 +534,7 @@ void RLRouletteLayer::onNextButton(CCObject*)
 		);
 	}
 	else
-		// this->addChild(TextAlertPopup::create(
-		// 	std::format(
-		// 		"You need to get at least {}%!", static_cast<int>(g_rouletteManager.levelPercentageGoal)
-		// 	), 1.2f, .8f, 1, "bigFont.fnt"
-		// ));
-		Notification::create(
-			fmt::format("You need to get at least {}%!", g_rouletteManager.levelPercentageGoal),
-			NotificationIcon::Error,
-			.7f
-		)->show();
+		rl::utils::createNotificationToast(this, fmt::format("You need to get at least {}%!", g_rouletteManager.levelPercentageGoal), .5f, 85.f);
 }
 
 void RLRouletteLayer::onResetButton(CCObject*)
@@ -599,12 +589,7 @@ void RLRouletteLayer::onSkipButton(CCObject*)
 		);
 	}
 	else
-		// this->addChild(
-		// 	TextAlertPopup::create(
-		// 		"You don't have any skips left!", 1.2f, .8f, 1, "bigFont.fnt"
-		// 	)
-		// );
-		Notification::create("You don't have any skips left!", NotificationIcon::Error, .7f)->show();
+		rl::utils::createNotificationToast(this, "You don't have any skips left!", .5f, 85.f);
 }
 
 void RLRouletteLayer::finishLevelRoulette()

src/utils.hpp

@@ -182,6 +182,15 @@ namespace rl
 			return button;
 		}
 
+		inline void createNotificationToast(CCLayer* layer, const std::string& str, float time, float yPosition)
+		{
+			// yeah don't ask me what this is, ask IDA 👍
+			auto tap = TextAlertPopup::create(str, time, .6f, 0x96, "\x00\x00\x00\x00");
+			tap->setPositionY(yPosition);
+
+			layer->addChild(tap);
+		}
+
 		template<auto V>
 		struct ScopedVar
 		{