Skip to content
This repository was archived by the owner on Jan 8, 2023. It is now read-only.

Commit 44c6bcf

Browse files
committed
Change null checks to use operators
1 parent 5b9f17f commit 44c6bcf

File tree

4 files changed

+7
-11
lines changed

4 files changed

+7
-11
lines changed

src/main/java/io/github/spair/byond/dmi/CheckSupplierUtil.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,17 @@
11
package io.github.spair.byond.dmi;
22

3-
import java.util.Objects;
43
import java.util.function.BooleanSupplier;
54
import java.util.function.Function;
65

76
final class CheckSupplierUtil {
87

98
static <T, R> R returnIfNonNull(final T toCheck, final Function<T, R> toApply) {
10-
return Objects.nonNull(toCheck) ? toApply.apply(toCheck) : null;
9+
return toCheck != null ? toApply.apply(toCheck) : null;
1110
}
1211

1312
static <T, R> R returnIfNonNullAndTrue(
1413
final T toCheck, final BooleanSupplier boolCheck, final Function<T, R> toApply) {
15-
return Objects.nonNull(toCheck) && boolCheck.getAsBoolean() ? toApply.apply(toCheck) : null;
14+
return toCheck != null && boolCheck.getAsBoolean() ? toApply.apply(toCheck) : null;
1615
}
1716

1817
private CheckSupplierUtil() {

src/main/java/io/github/spair/byond/dmi/Diff.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
import javax.annotation.Nonnull;
88
import javax.annotation.Nullable;
9-
import java.util.Objects;
109

1110
@Data
1211
@Setter(AccessLevel.PACKAGE)
@@ -25,11 +24,11 @@ public class Diff {
2524
this.oldSprite = oldSprite;
2625
this.newSprite = newSprite;
2726

28-
if (Objects.nonNull(oldSprite) && Objects.nonNull(newSprite)) {
27+
if (oldSprite != null && newSprite != null) {
2928
status = DiffStatus.MODIFIED;
30-
} else if (Objects.isNull(oldSprite) && Objects.nonNull(newSprite)) {
29+
} else if (oldSprite == null && newSprite != null) {
3130
status = DiffStatus.CREATED;
32-
} else if (Objects.nonNull(oldSprite)) {
31+
} else if (oldSprite != null) {
3332
status = DiffStatus.DELETED;
3433
} else {
3534
throw new IllegalArgumentException("Original and Modified sprites are null. State name: " + stateName);

src/main/java/io/github/spair/byond/dmi/DmiComparator.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import java.util.Map;
88
import java.util.Optional;
99
import java.util.Collections;
10-
import java.util.Objects;
1110
import java.util.stream.Collectors;
1211

1312
/**
@@ -44,7 +43,7 @@ private static List<Diff> getDiffList(@Nullable final Dmi oldDmi, @Nullable fina
4443
oldStates.forEach((stateName, oldState) -> {
4544
final DmiState newState = newStates.get(stateName);
4645

47-
if (Objects.nonNull(newState)) {
46+
if (newState != null) {
4847
diffEntries.addAll(findOldAndNewStateDiff(oldState, newState));
4948
} else {
5049
diffEntries.addAll(listOnlyOneStateSprites(oldState, true));

src/main/java/io/github/spair/byond/dmi/MetaExtractor.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import javax.imageio.stream.ImageInputStream;
1010
import java.io.IOException;
1111
import java.io.InputStream;
12-
import java.util.Objects;
1312
import java.util.List;
1413
import java.util.ArrayList;
1514
import java.util.Arrays;
@@ -67,7 +66,7 @@ private static DmiMeta parseMetadataText(final String metadataText) {
6766
DmiMeta metadata = new DmiMeta();
6867
Matcher widthHeight = WIDTH_HEIGHT.matcher(metadataText);
6968

70-
if (widthHeight.find() && Objects.nonNull(widthHeight.group(1)) && Objects.nonNull(widthHeight.group(2))) {
69+
if (widthHeight.find() && widthHeight.group(1) != null && widthHeight.group(2) != null) {
7170
metadata.setSpritesWidth(Integer.parseInt(widthHeight.group(1)));
7271
metadata.setSpritesHeight(Integer.parseInt(widthHeight.group(2)));
7372
} else {

0 commit comments

Comments
 (0)