Fixes incorrect valueOf conversion

Author: SpaiR

src/main/java/io/github/spair/byond/dmi/Diff.java

@@ -9,6 +9,7 @@
 import java.util.Objects;
 
 @Data
+@Setter(AccessLevel.PACKAGE)
 @SuppressWarnings("WeakerAccess")
 public class Diff {
 
@@ -19,9 +20,7 @@ public class Diff {
     @Setter(AccessLevel.NONE)
     @Nonnull private DiffStatus status;
 
-    public Diff(@Nonnull final String stateName,
-                @Nullable final DmiSprite oldSprite,
-                @Nullable final DmiSprite newSprite) {
+    Diff(@Nonnull final String stateName, @Nullable final DmiSprite oldSprite, @Nullable final DmiSprite newSprite) {
         this.stateName = stateName;
         this.oldSprite = oldSprite;
         this.newSprite = newSprite;

src/main/java/io/github/spair/byond/dmi/DmiDiff.java

@@ -1,20 +1,27 @@
 package io.github.spair.byond.dmi;
 
+import lombok.AccessLevel;
 import lombok.Data;
+import lombok.Setter;
 
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 import java.util.List;
 import java.util.Objects;
 
 @Data
+@Setter(AccessLevel.PACKAGE)
 @SuppressWarnings("WeakerAccess")
 public class DmiDiff {
 
     @Nullable private DmiMeta oldMeta;
     @Nullable private DmiMeta newMeta;
     @Nonnull private List<Diff> diffs;
 
+    DmiDiff(@Nonnull final List<Diff> diffs) {
+        this.diffs = diffs;
+    }
+
     /**
      * Shows that current diff was generated from the same Dmi's.
      * @return true, if Dmi's was the same, otherwise false

src/main/java/io/github/spair/byond/dmi/DmiMeta.java

@@ -1,8 +1,8 @@
 package io.github.spair.byond.dmi;
 
-import lombok.AllArgsConstructor;
 import lombok.Data;
 import lombok.NoArgsConstructor;
+import lombok.AllArgsConstructor;
 
 import java.util.List;
 

src/main/java/io/github/spair/byond/dmi/SpriteDir.java

@@ -12,16 +12,6 @@ public enum SpriteDir {
     NORTHEAST(5, "NE", 7),
     NORTHWEST(9, "NW", 8);
 
-    private static final int NORTH_DIR = 1;
-    private static final int SOUTH_DIR = 2;
-    private static final int EAST_DIR = 4;
-    private static final int WEST_DIR = 8;
-
-    private static final int SOUTHEAST_DIR = 6;
-    private static final int SOUTHWEST_DIR = 10;
-    private static final int NORTHEAST_DIR = 5;
-    private static final int NORTHWEST_DIR = 9;
-
     /**
      * <p>BYOND representation of dir as int value.
      * <ul>
@@ -65,7 +55,7 @@ public enum SpriteDir {
      * Returns {@link SpriteDir} equivalent to BYOND dir value. If method got value different from the list below,
      * {@link IllegalArgumentException} will be thrown.
      * <ul>
-     *     <li>1 - NORTH</li>
+     *     <li>0,1,3,7 - NORTH</li>
      *     <li>2 - SOUTH</li>
      *     <li>4 - EAST</li>
      *     <li>8 - WEST</li>
@@ -78,23 +68,24 @@ public enum SpriteDir {
      * @param dirValue BYOND representation of dir
      * @return {@link SpriteDir} equivalent of BYOND dir value
      */
+    @SuppressWarnings("checkstyle:MagicNumber")
     public static SpriteDir valueOfByondDir(final int dirValue) {
         switch (dirValue) {
-            case NORTH_DIR:
+            case 0: case 1: case 3: case 7:
                 return NORTH;
-            case SOUTH_DIR:
+            case 2:
                 return SOUTH;
-            case EAST_DIR:
+            case 4:
                 return EAST;
-            case WEST_DIR:
+            case 8:
                 return WEST;
-            case NORTHEAST_DIR:
+            case 5:
                 return NORTHEAST;
-            case SOUTHEAST_DIR:
+            case 6:
                 return SOUTHEAST;
-            case NORTHWEST_DIR:
+            case 9:
                 return NORTHWEST;
-            case SOUTHWEST_DIR:
+            case 10:
                 return SOUTHWEST;
             default:
                 throw new IllegalArgumentException("Illegal value of BYOND dir. Dir value: " + dirValue);

src/test/java/io/github/spair/byond/dmi/SpriteDirTest.java

@@ -8,7 +8,10 @@ public class SpriteDirTest {
 
     @Test
     public void testValueOfByondDir() {
+        assertEquals(SpriteDir.NORTH, SpriteDir.valueOfByondDir(0));
         assertEquals(SpriteDir.NORTH, SpriteDir.valueOfByondDir(1));
+        assertEquals(SpriteDir.NORTH, SpriteDir.valueOfByondDir(3));
+        assertEquals(SpriteDir.NORTH, SpriteDir.valueOfByondDir(7));
         assertEquals(SpriteDir.SOUTH, SpriteDir.valueOfByondDir(2));
         assertEquals(SpriteDir.EAST, SpriteDir.valueOfByondDir(4));
         assertEquals(SpriteDir.WEST, SpriteDir.valueOfByondDir(8));
@@ -22,7 +25,7 @@ public void testValueOfByondDir() {
     @Test(expected = IllegalArgumentException.class)
     public void testValueOfByondDirWithIllegalValue() {
         //noinspection ResultOfMethodCallIgnored
-        SpriteDir.valueOfByondDir(0);
+        SpriteDir.valueOfByondDir(-1);
     }
 
     @Test