Skip to content
This repository was archived by the owner on Jan 8, 2023. It is now read-only.

Commit 61a1617

Browse files
committed
Replace getOrDefault with null check to avoid unneeded ArrayList creation
1 parent be1a80f commit 61a1617

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

src/main/java/io/github/spair/byond/dmi/DmiState.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,10 @@ public String getName() {
2525
}
2626

2727
public void addSprite(final DmiSprite sprite) {
28-
List<DmiSprite> spriteList = sprites.getOrDefault(sprite.getDir(), new ArrayList<>());
28+
List<DmiSprite> spriteList = sprites.get(sprite.getDir());
29+
if (spriteList == null) {
30+
spriteList = new ArrayList<>();
31+
}
2932
spriteList.add(sprite);
3033
sprites.putIfAbsent(sprite.getDir(), spriteList);
3134
}

src/main/java/io/github/spair/byond/dmi/slurper/StateExtractor.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,10 @@ private static Map<SpriteDir, List<DmiSprite>> distributeAllSpritesInMap(final L
7878
Map<SpriteDir, List<DmiSprite>> spriteMap = new TreeMap<>(dirComparator);
7979

8080
for (DmiSprite sprite : allSprites) {
81-
List<DmiSprite> spritesInDir = spriteMap.getOrDefault(sprite.getDir(), new ArrayList<>());
81+
List<DmiSprite> spritesInDir = spriteMap.get(sprite.getDir());
82+
if (spritesInDir == null) {
83+
spritesInDir = new ArrayList<>();
84+
}
8285
spritesInDir.add(sprite);
8386
spriteMap.putIfAbsent(sprite.getDir(), spritesInDir);
8487
}

0 commit comments

Comments
 (0)