Add checkstyle to imgui-binding and make everything compliant to Java codestyle

Author: SpaiR

config/checkstyle/checkstyle.xml

@@ -91,6 +91,10 @@
     <!-- Suppress warnings by using   -->
     <module name="SuppressWarningsFilter"/>
 
+    <module name="SuppressionFilter">
+        <property name="file" value="${config_loc}/suppressions.xml" />
+    </module>
+
     <module name="TreeWalker">
 
         <!-- Checks for Javadoc comments.                     -->
@@ -160,7 +164,10 @@
         <!-- See https://checkstyle.org/config_coding.html -->
         <module name="EmptyStatement"/>
         <module name="EqualsHashCode"/>
-        <module name="HiddenField"/>
+        <module name="HiddenField" >
+            <property name="ignoreSetter" value="true" />
+            <property name="ignoreConstructorParameter" value="true" />
+        </module>
         <module name="IllegalInstantiation"/>
         <module name="InnerAssignment"/>
         <module name="MagicNumber"/>
@@ -178,11 +185,11 @@
         <module name="VisibilityModifier"/>
 
         <!-- Miscellaneous other checks.                   -->
-        <!-- See https://checkstyle.org/config_misc.html -->
+        <!-- See https://checkstyle.org/config_misc.html   -->
         <module name="ArrayTypeStyle"/>
         <module name="FinalParameters"/>
         <module name="FinalLocalVariable"/>
-        <module name="TodoComment"/>
+        <!-- <module name="TodoComment"/>                  -->
         <module name="UpperEll"/>
 
         <!-- See https://checkstyle.sourceforge.io/config_annotation.html#SuppressWarningsHolder -->

config/checkstyle/suppressions.xml

@@ -0,0 +1,15 @@
+<?xml version="1.0"?>
+
+<!DOCTYPE suppressions PUBLIC
+        "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
+        "https://checkstyle.org/dtds/suppressions_1_2.dtd">
+
+<suppressions>
+    <suppress checks="MagicNumber" files="[\\/]imgui[\\/]"/>
+    <suppress checks="LineLength" files="[\\/]imgui[\\/]"/>
+    <suppress checks="ConstantName" files="[\\/]imgui[\\/]"/>
+    <suppress checks="VisibilityModifier" files="[\\/]imgui[\\/]"/>
+    <suppress checks="ParameterNumber" files="[\\/]imgui[\\/]"/>
+    <suppress checks="FileLength" files="[\\/]imgui[\\/]"/>
+    <suppress checks="FinalParameters" files="ImGui.java"/>
+</suppressions>

imgui-binding/build.gradle

@@ -2,6 +2,7 @@ import imgui.generate.GenerateLibs
 
 plugins {
     id 'java'
+    id 'checkstyle'
     id 'com.jfrog.bintray' version '1.8.4'
     id 'maven-publish'
 }

imgui-binding/src/main/java/imgui/ImBool.java

@@ -3,20 +3,20 @@
 import java.util.Objects;
 
 public final class ImBool {
-    boolean[] data = new boolean[]{false};
+    final boolean[] data = new boolean[]{false};
 
     public ImBool() {
     }
 
-    public ImBool(boolean value) {
+    public ImBool(final boolean value) {
         data[0] = value;
     }
 
     public boolean get() {
         return data[0];
     }
 
-    public void set(boolean value) {
+    public void set(final boolean value) {
         data[0] = value;
     }
 
@@ -26,10 +26,14 @@ public String toString() {
     }
 
     @Override
-    public boolean equals(Object o) {
-        if (this == o) return true;
-        if (o == null || getClass() != o.getClass()) return false;
-        ImBool imBool = (ImBool) o;
+    public boolean equals(final Object o) {
+        if (this == o) {
+            return true;
+        }
+        if (o == null || getClass() != o.getClass()) {
+            return false;
+        }
+        final ImBool imBool = (ImBool) o;
         return data[0] == imBool.data[0];
     }
 

imgui-binding/src/main/java/imgui/ImDouble.java

@@ -3,20 +3,20 @@
 import java.util.Objects;
 
 public final class ImDouble {
-    double[] data = new double[]{0.0d};
+    final double[] data = new double[]{0.0d};
 
     public ImDouble() {
     }
 
-    public ImDouble(double value) {
+    public ImDouble(final double value) {
         set(value);
     }
 
     public double get() {
         return this.data[0];
     }
 
-    public void set(double value) {
+    public void set(final double value) {
         this.data[0] = value;
     }
 
@@ -26,10 +26,14 @@ public String toString() {
     }
 
     @Override
-    public boolean equals(Object o) {
-        if (this == o) return true;
-        if (o == null || getClass() != o.getClass()) return false;
-        ImDouble imDouble = (ImDouble) o;
+    public boolean equals(final Object o) {
+        if (this == o) {
+            return true;
+        }
+        if (o == null || getClass() != o.getClass()) {
+            return false;
+        }
+        final ImDouble imDouble = (ImDouble) o;
         return data[0] == imDouble.data[0];
     }
 

imgui-binding/src/main/java/imgui/ImDrawData.java

@@ -9,9 +9,9 @@
  * BINDING NOTICE: DO NOT TRY TO MODIFY FIELDS OF THIS CLASS MANUALLY! You should only access their values after {@link ImGui#Render()} call.
  */
 public final class ImDrawData {
-    public static int V_BUFFER_SIZE = (4 + 1) * 4;
-    public static int I_BUFFER_SIZE = 2;
-    public static int CMD_BUFFER_SIZE = (1 + 4 + 1) * 4;
+    public static final int V_BUFFER_SIZE = (4 + 1) * 4;
+    public static final int I_BUFFER_SIZE = 2;
+    public static final int CMD_BUFFER_SIZE = (1 + 4 + 1) * 4;
 
     public ByteBuffer vByteBuffer;
     public ByteBuffer iByteBuffer;
@@ -37,7 +37,7 @@ public final class ImDrawData {
     public float framebufferScaleX;
     public float framebufferScaleY;
 
-    ImDrawData(int maxVertices, int maxIndices, int maxCmd) {
+    ImDrawData(final int maxVertices, final int maxIndices, final int maxCmd) {
         vByteBuffer = ByteBuffer.allocateDirect(maxVertices * V_BUFFER_SIZE).order(ByteOrder.nativeOrder());
         iByteBuffer = ByteBuffer.allocateDirect(maxIndices * I_BUFFER_SIZE).order(ByteOrder.nativeOrder());
         cmdByteBuffer = ByteBuffer.allocateDirect(maxCmd * CMD_BUFFER_SIZE).order(ByteOrder.nativeOrder());