Skip to content

Commit d760b2b

Browse files
committed
[API] Tweak ImString tests
1 parent 47baed3 commit d760b2b

File tree

3 files changed

+87
-71
lines changed

3 files changed

+87
-71
lines changed
Lines changed: 85 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -1,91 +1,107 @@
11
package imgui;
22

33
import imgui.type.ImString;
4+
import org.junit.jupiter.api.Nested;
45
import org.junit.jupiter.api.Test;
56

67
import static org.junit.jupiter.api.Assertions.assertEquals;
78

89
class ImStringTest {
9-
@Test
10-
public void testCreation() {
11-
ImString str = new ImString(10);
12-
assertEquals("", str.get());
13-
assertEquals(0, str.getLength(), "String length should be 0, since no data was provided");
14-
assertEquals(10 + 1, str.getBufferSize(), "Buffer size must be 'length + 1', +1 - size of the ImGui caret");
10+
@Nested
11+
class constructor {
12+
@Test
13+
void withLength() {
14+
final ImString str = new ImString(10);
15+
assertEquals("", str.get());
16+
assertEquals(0, str.getLength(), "String length should be 0, since no data was provided");
17+
assertEquals(10 + 1, str.getBufferSize(), "Buffer size must be 'length + 1', +1 - size of the ImGui caret");
18+
}
1519

16-
str = new ImString("test");
17-
assertEquals("test", str.get());
18-
assertEquals(4, str.getLength());
19-
assertEquals(4 + 1, str.getBufferSize());
20+
@Test
21+
void withString() {
22+
final ImString str = new ImString("test");
23+
assertEquals("test", str.get());
24+
assertEquals(4, str.getLength());
25+
assertEquals(4 + 1, str.getBufferSize());
26+
}
2027

21-
str = new ImString("test", 10);
22-
assertEquals("test", str.get());
23-
assertEquals(4, str.getLength());
24-
assertEquals(10 + 1, str.getBufferSize());
28+
@Test
29+
void withStringAndLength() {
30+
final ImString str = new ImString("test", 10);
31+
assertEquals("test", str.get());
32+
assertEquals(4, str.getLength());
33+
assertEquals(10 + 1, str.getBufferSize());
34+
}
2535
}
2636

27-
@Test
28-
public void testGet() {
29-
final ImString str = new ImString("test");
30-
assertEquals("test", str.get());
31-
assertEquals(str.get(), str.toString(), "ImString#toString() must return value which should be equal to ImString#get()");
37+
@Nested
38+
class get {
39+
@Test
40+
void simple() {
41+
final ImString str = new ImString("test");
42+
assertEquals("test", str.get());
43+
assertEquals(str.get(), str.toString(), "ImString#toString() must return value which should be equal to ImString#get()");
44+
}
3245
}
3346

34-
@Test
35-
public void testSetWhenEmpty() {
36-
final ImString str = new ImString(3);
37-
assertEquals("", str.get());
38-
assertEquals(0, str.getLength());
39-
assertEquals(3 + 1, str.getBufferSize());
40-
}
47+
@Nested
48+
class set {
49+
@Test
50+
void withEmpty() {
51+
final ImString str = new ImString(3);
52+
assertEquals("", str.get());
53+
assertEquals(0, str.getLength());
54+
assertEquals(3 + 1, str.getBufferSize());
55+
}
4156

42-
@Test
43-
public void testSetWhenNotResized() {
44-
final ImString str = new ImString(3);
45-
str.set("test");
46-
assertEquals("tes", str.get());
47-
assertEquals(3, str.getLength());
48-
assertEquals(3 + 1, str.getBufferSize());
49-
}
57+
@Test
58+
void withNotResized() {
59+
final ImString str = new ImString(3);
60+
str.set("test");
61+
assertEquals("tes", str.get());
62+
assertEquals(3, str.getLength());
63+
assertEquals(3 + 1, str.getBufferSize());
64+
}
5065

51-
@Test
52-
public void testSetWhenResizedWithZeroResizeValue() {
53-
final ImString str = new ImString(3);
54-
str.set("test", true, 0);
55-
assertEquals("test", str.get());
56-
assertEquals(4, str.getLength());
57-
assertEquals(4 + 1, str.getBufferSize());
58-
}
66+
@Test
67+
void withResizedWithZeroResizeValue() {
68+
final ImString str = new ImString(3);
69+
str.set("test", true, 0);
70+
assertEquals("test", str.get());
71+
assertEquals(4, str.getLength());
72+
assertEquals(4 + 1, str.getBufferSize());
73+
}
5974

60-
@Test
61-
public void testSetWhenResized() {
62-
final ImString str = new ImString(3);
63-
str.set("0123456789", true);
64-
assertEquals("0123456789", str.get());
65-
assertEquals(10, str.getLength());
66-
assertEquals(10 + str.inputData.resizeFactor + 1, str.getBufferSize());
67-
}
75+
@Test
76+
void withResized() {
77+
final ImString str = new ImString(3);
78+
str.set("0123456789", true);
79+
assertEquals("0123456789", str.get());
80+
assertEquals(10, str.getLength());
81+
assertEquals(10 + str.inputData.resizeFactor + 1, str.getBufferSize());
82+
}
6883

69-
@Test
70-
public void testSetWhenNullObject() {
71-
final ImString str = new ImString();
72-
final Object object = null;
73-
str.set(object);
74-
assertEquals("null", str.get());
75-
}
84+
@Test
85+
void withNullObject() {
86+
final ImString str = new ImString();
87+
final Object object = null;
88+
str.set(object);
89+
assertEquals("null", str.get());
90+
}
7691

77-
@Test
78-
public void testSetWhenImString() {
79-
final ImString str = new ImString();
80-
final ImString string = new ImString("test");
81-
str.set(string);
82-
assertEquals("test", str.get());
83-
}
92+
@Test
93+
void withImString() {
94+
final ImString str = new ImString();
95+
final ImString string = new ImString("test");
96+
str.set(string);
97+
assertEquals("test", str.get());
98+
}
8499

85-
@Test
86-
public void testSetWhenNumber() {
87-
final ImString str = new ImString();
88-
str.set(123);
89-
assertEquals("123", str.get());
100+
@Test
101+
void withNumber() {
102+
final ImString str = new ImString();
103+
str.set(123);
104+
assertEquals("123", str.get());
105+
}
90106
}
91107
}

imgui-binding/src/test/java/imgui/ImVec2Test.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import org.junit.jupiter.api.Nested;
44
import org.junit.jupiter.api.Test;
55

6-
import static org.junit.jupiter.api.Assertions.*;
6+
import static org.junit.jupiter.api.Assertions.assertEquals;
77

88
class ImVec2Test {
99
@Nested

imgui-binding/src/test/java/imgui/ImVec4Test.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import org.junit.jupiter.api.Nested;
44
import org.junit.jupiter.api.Test;
55

6-
import static org.junit.jupiter.api.Assertions.*;
6+
import static org.junit.jupiter.api.Assertions.assertEquals;
77

88
class ImVec4Test {
99
@Nested

0 commit comments

Comments
 (0)