review and minor cleanup

Author: cayossarian

custom_components/span_panel/manifest.json

@@ -10,7 +10,7 @@
 	"iot_class": "local_polling",
 	"issue_tracker": "https://github.com/SpanPanel/span/issues",
 	"requirements": [],
-	"version": "0.0.13",
+	"version": "0.0.13-beta",
 	"zeroconf": [
 		{
 			"type": "_span._tcp.local."

custom_components/span_panel/sensor.py

@@ -374,6 +374,7 @@ def native_value(self) -> str | None:
 
 
 class SpanPanelStorageBatteryStatus(CoordinatorEntity, SensorEntity):
+    """Battery Status"""
     _attr_icon = "mdi:battery"
 
     def __init__(

custom_components/span_panel/span_panel.py

@@ -33,6 +33,7 @@
 SYSTEM_CELLULAR_LINK = "wwanLink"
 SYSTEM_WIFI_LINK = "wlanLink"
 
+
 class SpanPanel:
     """Instance of a Span panel"""
 
@@ -68,4 +69,4 @@ async def update(self) -> None:
             self.storage_battery = await self.api.get_storage_battery_data()
 
         except SpanPanelReturnedEmptyData:
-            _LOGGER.warn("Span Panel API returned empty result. Ignoring...")
+            _LOGGER.warn("Span Panel API returned empty result for battery storage. Ignoring...")

custom_components/span_panel/span_panel_api.py

@@ -21,6 +21,7 @@
 from .span_panel_status import SpanPanelStatus
 from .span_panel_storage_battery import SpanPanelStorageBattery
 
+
 _LOGGER = logging.getLogger(__name__)
 
 

custom_components/span_panel/span_panel_storage_battery.py

@@ -1,10 +1,15 @@
+"""span_panel_storage_battery"""
 import dataclasses
-from typing import Any
+from typing import Any, Dict
 
 @dataclasses.dataclass
 class SpanPanelStorageBattery:
+    """Class to manage the storage battery data."""
     storage_battery_percentage: int
 
     @staticmethod
-    def from_dic(data):
-        return data
+    def from_dic(data: Dict[str, Any]) -> "SpanPanelStorageBattery":
+        """read the data from the dictionary"""
+        return SpanPanelStorageBattery(
+            storage_battery_percentage=int(data.get('storage_battery_percentage', 0))
+        )