use the helper function to create descriptor

Author: yhmtsai

include/spblas/vendor/cusparse/descriptor.hpp

@@ -0,0 +1,45 @@
+#pragma once
+
+#include <type_traits>
+
+#include <cusparse.h>
+
+#include <spblas/concepts.hpp>
+#include <spblas/views/inspectors.hpp>
+
+#include "exception.hpp"
+#include "types.hpp"
+
+namespace spblas {
+namespace __cusparse {
+
+// create matrix descriptor from spblas csr view
+template <matrix mat>
+  requires __detail::is_csr_view_v<mat>
+cusparseSpMatDescr_t create_matrix_descr(mat&& a) {
+  using matrix_type = std::remove_cvref_t<mat>;
+  cusparseSpMatDescr_t descr;
+  throw_if_error(cusparseCreateCsr(
+      &descr, __backend::shape(a)[0], __backend::shape(a)[1], a.values().size(),
+      a.rowptr().data(), a.colind().data(), a.values().data(),
+      to_cusparse_indextype<typename matrix_type::offset_type>(),
+      to_cusparse_indextype<typename matrix_type::index_type>(),
+      CUSPARSE_INDEX_BASE_ZERO,
+      to_cuda_datatype<typename matrix_type::scalar_type>()));
+  return descr;
+}
+
+// create dense vector from mdspan
+template <vector vec>
+  requires __ranges::contiguous_range<vec>
+cusparseDnVecDescr_t create_vector_descr(vec&& v) {
+  using vector_type = std::remove_cvref_t<vec>;
+  cusparseDnVecDescr_t descr;
+  throw_if_error(cusparseCreateDnVec(
+      &descr, v.size(), v.data(),
+      to_cuda_datatype<typename vector_type::value_type>()));
+  return descr;
+}
+
+} // namespace __cusparse
+} // namespace spblas

include/spblas/vendor/cusparse/multiply.hpp

@@ -11,6 +11,7 @@
 #include <spblas/detail/view_inspectors.hpp>
 
 #include "cuda_allocator.hpp"
+#include "descriptor.hpp"
 #include "exception.hpp"
 #include "types.hpp"
 
@@ -59,23 +60,9 @@ class spmv_state_t {
     tensor_scalar_t<A> alpha = alpha_optional.value_or(1);
     auto handle = this->handle_.get();
 
-    cusparseSpMatDescr_t mat;
-    __cusparse::throw_if_error(cusparseCreateCsr(
-        &mat, __backend::shape(a_base)[0], __backend::shape(a_base)[1],
-        a_base.values().size(), a_base.rowptr().data(), a_base.colind().data(),
-        a_base.values().data(),
-        to_cusparse_indextype<typename matrix_type::offset_type>(),
-        to_cusparse_indextype<typename matrix_type::index_type>(),
-        CUSPARSE_INDEX_BASE_ZERO, to_cuda_datatype<value_type>()));
-
-    cusparseDnVecDescr_t vecb;
-    cusparseDnVecDescr_t vecc;
-    __cusparse::throw_if_error(cusparseCreateDnVec(
-        &vecb, b_base.size(), b_base.data(),
-        to_cuda_datatype<typename input_type::value_type>()));
-    __cusparse::throw_if_error(cusparseCreateDnVec(
-        &vecc, c.size(), c.data(),
-        to_cuda_datatype<typename output_type::value_type>()));
+    auto mat = __cusparse::create_matrix_descr(a_base);
+    auto vecb = __cusparse::create_vector_descr(b_base);
+    auto vecc = __cusparse::create_vector_descr(c);
 
     value_type alpha_val = alpha;
     value_type beta = 0.0;

include/spblas/vendor/cusparse/multiply_spgemm.hpp

@@ -11,6 +11,7 @@
 #include <spblas/detail/view_inspectors.hpp>
 
 #include "cuda_allocator.hpp"
+#include "descriptor.hpp"
 #include "exception.hpp"
 #include "types.hpp"
 
@@ -78,27 +79,12 @@ class spgemm_state_t {
     value_type alpha = alpha_optional.value_or(1);
     value_type beta = 1;
     auto handle = this->handle_.get();
-    // Create sparse matrix A in CSR format
-    __cusparse::throw_if_error(cusparseCreateCsr(
-        &mat_a_, __backend::shape(a_base)[0], __backend::shape(a_base)[1],
-        a_base.values().size(), a_base.rowptr().data(), a_base.colind().data(),
-        a_base.values().data(),
-        to_cusparse_indextype<typename matrix_type::offset_type>(),
-        to_cusparse_indextype<typename matrix_type::index_type>(),
-        CUSPARSE_INDEX_BASE_ZERO, to_cuda_datatype<value_type>()));
-    __cusparse::throw_if_error(cusparseCreateCsr(
-        &mat_b_, __backend::shape(b_base)[0], __backend::shape(b_base)[1],
-        b_base.values().size(), b_base.rowptr().data(), b_base.colind().data(),
-        b_base.values().data(),
-        to_cusparse_indextype<typename matrix_type::offset_type>(),
-        to_cusparse_indextype<typename matrix_type::index_type>(),
-        CUSPARSE_INDEX_BASE_ZERO, to_cuda_datatype<value_type>()));
-    __cusparse::throw_if_error(cusparseCreateCsr(
-        &mat_c_, __backend::shape(a)[0], __backend::shape(b)[1], 0,
-        c.rowptr().data(), NULL, NULL,
-        to_cusparse_indextype<typename matrix_type::offset_type>(),
-        to_cusparse_indextype<typename matrix_type::index_type>(),
-        CUSPARSE_INDEX_BASE_ZERO, to_cuda_datatype<value_type>()));
+    __cusparse::throw_if_error(cusparseDestroySpMat(mat_a_));
+    __cusparse::throw_if_error(cusparseDestroySpMat(mat_b_));
+    __cusparse::throw_if_error(cusparseDestroySpMat(mat_c_));
+    mat_a_ = __cusparse::create_matrix_descr(a_base);
+    mat_b_ = __cusparse::create_matrix_descr(b_base);
+    mat_c_ = __cusparse::create_matrix_descr(c);
 
     // ask bufferSize1 bytes for external memory
     size_t buffer_size_1 = 0;
@@ -183,9 +169,9 @@ class spgemm_state_t {
   char* workspace_2_;
   index<index_t> result_shape_;
   index_t result_nnz_;
-  cusparseSpMatDescr_t mat_a_;
-  cusparseSpMatDescr_t mat_b_;
-  cusparseSpMatDescr_t mat_c_;
+  cusparseSpMatDescr_t mat_a_ = nullptr;
+  cusparseSpMatDescr_t mat_b_ = nullptr;
+  cusparseSpMatDescr_t mat_c_ = nullptr;
   cusparseSpGEMMDescr_t descr_;
 };