How to test imports

[LarryBarker]

Hello, we are using the package to import users into our system. Our import class creates a new model using the toRow() method. The controller simply uses the import() method:

(new UsersImport)->import($request->file('users'));

What's interesting is I don't think the import is being stored on the file system. We are just pulling data from it and creating records.

I have tried testing based on the documentation and all I'm getting is that the file doesn't exist on the file system.

I also found an issue that reported an error with using UploadedFile and undefined index error. These suggestions did not work for me either (I get the original error still).

Has anyone successfully tested this scenario?

[patrickbrouwers]

Excel::fake();

Excel::import(new UsersImport(1, 1, 14), $this->getTestFile('users.csv'));

Excel::assertImported('test/files/users.csv', 'default');

I saw this test in another comment, is this your actual test? Or is this simplified and is the import inside a controller?

[LarryBarker]

This is my actual test. Here's a screen shot:

When you ask "is the import inside the controller," are you asking if I'm importing the file through a controller? If so, then yes.

    public function ImportUsers(Request $request): JsonResponse
    {
        $this->userService->validateImportUsersRequest();

        $import = new UsersImport(
            (int)request('school'),
            (int)request('path'),
            (int)request('duration'),
            $this->userService->getIsImportingSso()
        );

        $import->import($request->file("CsvImport"));

        return response()->json(['success' => "Yeah"], 200);
    }

[patrickbrouwers]

That doesn't really seem like a valuable test to me. You basically are testing if the testing helper works now. None of the logic within the import is tested this way.
It's like queue fakes, the job itself isn't executed; you only test if it was dispatched correctly.

Depending on what you want to exactly test a different type of test will be more useful.

You could either write a full integration test in which you test that the data is actually imported. Or you test that a call to that controller method actually calls the import script (mock).

For the uploaded file you can probably better use the ::fake() that Laravel itself provides.

[LarryBarker]

Sure I understand what you mean. I guess I need some direction on what to test exactly. The controller?

…

On Thu, May 6, 2021 at 10:20 AM Patrick Brouwers ***@***.***> wrote: That doesn't really seem like a valuable test to me. You basically are testing if the testing helper works now. None of the logic within the export is tested this way. It's like queue fakes, the job itself isn't executed; you only test if it was dispatched correctly. Depending on what you want to exactly test a different type of test will be more useful. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3148 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG3HK7B7POBNKIA3SAEX3B3TMKXVVANCNFSM44GGVUFA> .