laravel excel row validation with multiple sheet is not capturing validation errors (failures)

[farshadff]

i am using laravel excel to import excel and using WithMultipleSheets so my main import class is like below :

class OrderFileImport implements WithMultipleSheets,WithChunkReading,SkipsOnFailure
{
    use SkipsFailures,Importable;

    private $request;
    public function __construct(array $request)
    {
        $this->request = $request;
    }
    public function chunkSize(): int
    {
        return 20;
    }
    public function sheets(): array
    {
        return [
            'Sheet1' => new FirstSheetImport($this->request),
        ];
    }
}

and my FirstSheetImport is like :

class FirstSheetImport implements ToModel,WithStartRow,WithChunkReading,WithValidation,SkipsOnFailure
{
    use SkipsFailures;
    private $request;
    public function __construct(array $request)
    {
        $this->request = $request;
    }
    /**
    * @param array $row
    */
    public function model(array $row)
    {
       some insert in here .
    }
    public function rules(): array
    {
        return [
            '20' => function($attribute, $value, $onFailure) {
                //some validation here
                if (!$validate) {
                    \Log::critical('Name is not Patrick Brouwers');
                    $onFailure('Name is not Patrick Brouwers');
                } else {
                    \Log::critical('test');
                }
            }
        ];
    }


}

now the problem is that laravel excel is not gathering the failures though i can see the validation fails with the log i placed in the fail section but in my controller its not capturing the failures like below :

$import = new OrderFileImport($request->except('file'));
        $fileName = uniqid().'.xlsx';
        $request->file('file')->move(storage_path('/excels'),$fileName);
       $import->Sheets('Sheet1');

       Excel::Import($import,storage_path('excels/'.$fileName));
       foreach ($import->failures() as $failure) {
            dd($failure);
           $failure->row(); // row that went wrong
       }

i have placed a dd on failures but it always returns empty . i belive its because i am using the multiple sheets because on docs it says that i have to use it like this :

$import = new UsersImport();
$import->import('users.xlsx');

which with multiple sheets i dont think i can use import like above .
thanks in advance

[farshadff]

the point is that with the same code and without SkipsOnFailure i could receive the failures on try catch but now i cant get them

[patrickbrouwers]

Best to provide a failing unit test with an easy to reproduce scenario here: https://github.com/SpartnerNL/Laravel-Excel/blob/3.1/tests/Concerns/SkipsOnFailureTest.php Will make it easier to look into it

[farshadff]

i finally could get the failures by some changes that you wrote on some other threat .
#2034
in this link you said to change the sheets function like below :

 public function sheets(): array
    {
        $this->sheets = [
            new FirstSheetImport($this->request,$this->importedBy)
        ];
        return $this->sheets;

    }
    public function failures()
    {
        foreach($this->sheets as $sheet)
        {
            return $sheet->failures();
        }

    }

but now in my controller my code cant find the name of sheet and its not inserting any thing in database like below :

        $import = new OrderFileImport($request->except('file'),Auth::user());
        $fileName = uniqid().'.xlsx';
        $request->file('file')->move(storage_path('/excels'),$fileName);
       $import->Sheets('Sheet1');  // this line is grayed out now -> Method call is provided 1 parameters, but the method signature uses 0 parameters
       Excel::Import($import,storage_path('excels/'.$fileName));
       dd($import->failures());

the method says Method call is provided 1 parameters, but the method signature uses 0 parameters . any idea how to use sheets function ?

[patrickbrouwers]

I don't know what you are trying to do with $import->Sheets('Sheet1'), but you don't need to call that method