Laravel Vapor Support: downloadExcel Eloquent Mixin #3602
Unanswered
agraaff-inhance
asked this question in
Q&A
Replies: 1 comment
-
@agraaff-inhance I'm fine with that PR yes |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Right now the downloadExcel Eloquent mixin function does not support adding the necessary headers to allow Excel file downloads when running on Vapor. The required header is "X-Vapor-Base64-Encode: true". I have Laravel Excel does support adding headers to responses but does not surface it throughh the Mixin. Would it be okay to submit a PR to add a 'headers' variable to the downloadExcel callback function definition in DownloadCollection.php and then adding it to the $export->download() call in the last line of the callback function.
Beta Was this translation helpful? Give feedback.
All reactions