Create description only when needed

Author: pergerch

samples/SpatialFocus.EntityFrameworkCore.Extensions.SQLiteDemo/Entities/SpecialOccasion.cs

@@ -22,6 +22,6 @@ public enum SpecialOccasion
 		Valentines,
 
 		[Description("Marriage anniversary")]
-		Wedding,
+		WeddingDay,
 	}
 }

src/SpatialFocus.EntityFrameworkCore.Extensions/EnumLookupExtension.cs

@@ -38,9 +38,26 @@ public static void ConfigureEnumLookup(this ModelBuilder modelBuilder, EnumLooku
 
 				IMutableEntityType entityType = property.DeclaringEntityType;
 
-				Type concreteType = enumOptions.UseNumberLookup
-					? typeof(EnumWithNumberLookup<>).MakeGenericType(propertyType.GetEnumOrNullableEnumType())
-					: typeof(EnumWithStringLookup<>).MakeGenericType(propertyType.GetEnumOrNullableEnumType());
+				Dictionary<int, string> enumValueDescriptions = Enum.GetValues(propertyType.GetEnumOrNullableEnumType())
+					.Cast<Enum>()
+					.ToDictionary(Convert.ToInt32, GetEnumDescription);
+
+				bool usesDescription = enumValueDescriptions.Values.Any(x => x != null);
+
+				Type concreteType;
+				if (usesDescription)
+				{
+					concreteType = enumOptions.UseNumberLookup
+						? typeof(EnumWithNumberLookupAndDescription<>).MakeGenericType(propertyType.GetEnumOrNullableEnumType())
+						: typeof(EnumWithStringLookupAndDescription<>).MakeGenericType(propertyType.GetEnumOrNullableEnumType());
+				}
+				else
+				{
+					concreteType = enumOptions.UseNumberLookup
+						? typeof(EnumWithNumberLookup<>).MakeGenericType(propertyType.GetEnumOrNullableEnumType())
+						: typeof(EnumWithStringLookup<>).MakeGenericType(propertyType.GetEnumOrNullableEnumType());
+				}
+
 				EntityTypeBuilder enumLookupBuilder = modelBuilder.Entity(concreteType);
 
 				string typeName = propertyType.GetEnumOrNullableEnumType().Name;
@@ -56,8 +73,7 @@ public static void ConfigureEnumLookup(this ModelBuilder modelBuilder, EnumLooku
 				{
 					modelBuilder.Entity(concreteType).HasIndex(nameof(EnumWithNumberLookup<Enum>.Name)).IsUnique();
 				}
-
-				if (!enumOptions.UseNumberLookup)
+				else
 				{
 					Type converterType = typeof(EnumToStringConverter<>).MakeGenericType(propertyType.GetEnumOrNullableEnumType());
 					ValueConverter valueConverter = (ValueConverter)Activator.CreateInstance(converterType, new object[] { null });
@@ -73,10 +89,6 @@ public static void ConfigureEnumLookup(this ModelBuilder modelBuilder, EnumLooku
 
 				ConcreteTypeSeededList.Add(concreteType);
 
-				Dictionary<int, string> enumValueDescriptions = Enum.GetValues(propertyType.GetEnumOrNullableEnumType())
-					.Cast<Enum>()
-					.ToDictionary(Convert.ToInt32, GetEnumDescription);
-
 				// TODO: Check status of https://github.com/aspnet/EntityFrameworkCore/issues/12194 before using migrations
 				object[] data = Enum.GetValues(propertyType.GetEnumOrNullableEnumType())
 					.OfType<object>()
@@ -88,14 +100,22 @@ public static void ConfigureEnumLookup(this ModelBuilder modelBuilder, EnumLooku
 						{
 							concreteType.GetProperty(nameof(EnumWithNumberLookup<object>.Id)).SetValue(instance, x);
 							concreteType.GetProperty(nameof(EnumWithNumberLookup<object>.Name)).SetValue(instance, x.ToString());
-							concreteType.GetProperty(nameof(EnumWithNumberLookup<object>.Description))
-								.SetValue(instance, enumValueDescriptions[(int)x]);
+
+							if (usesDescription)
+							{
+								concreteType.GetProperty(nameof(EnumWithNumberLookupAndDescription<object>.Description))
+									.SetValue(instance, enumValueDescriptions[(int)x]);
+							}
 						}
 						else
 						{
 							concreteType.GetProperty(nameof(EnumWithStringLookup<object>.Id)).SetValue(instance, x);
-							concreteType.GetProperty(nameof(EnumWithNumberLookup<object>.Description))
-								.SetValue(instance, enumValueDescriptions[(int)x]);
+
+							if (usesDescription)
+							{
+								concreteType.GetProperty(nameof(EnumWithNumberLookupAndDescription<object>.Description))
+									.SetValue(instance, enumValueDescriptions[(int)x]);
+							}
 						}
 
 						return instance;
@@ -108,9 +128,9 @@ public static void ConfigureEnumLookup(this ModelBuilder modelBuilder, EnumLooku
 
 		public static string GetEnumDescription(Enum value)
 		{
-			FieldInfo fi = value.GetType().GetField(value.ToString());
+			FieldInfo fieldInfo = value.GetType().GetField(value.ToString());
 
-			DescriptionAttribute attribute = (DescriptionAttribute)fi.GetCustomAttribute(typeof(DescriptionAttribute), true);
+			DescriptionAttribute attribute = (DescriptionAttribute)fieldInfo.GetCustomAttribute(typeof(DescriptionAttribute), true);
 
 			return attribute?.Description;
 		}

src/SpatialFocus.EntityFrameworkCore.Extensions/EnumWithNumberLookup.cs

@@ -19,8 +19,6 @@ public EnumWithNumberLookup(T value)
 			Name = value.ToString();
 		}
 
-		public string Description { get; set; }
-
 		[DatabaseGenerated(DatabaseGeneratedOption.None)]
 		public T Id { get; set; }
 

src/SpatialFocus.EntityFrameworkCore.Extensions/EnumWithNumberLookupAndDescription.cs

@@ -0,0 +1,22 @@
+// <copyright file="EnumWithNumberLookupAndDescription.cs" company="Spatial Focus">
+// Copyright (c) Spatial Focus. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+// </copyright>
+
+namespace SpatialFocus.EntityFrameworkCore.Extensions
+{
+	public class EnumWithNumberLookupAndDescription<T> : EnumWithNumberLookup<T>
+	{
+		public EnumWithNumberLookupAndDescription()
+			: base()
+		{
+		}
+
+		public EnumWithNumberLookupAndDescription(T value)
+			: base(value)
+		{
+		}
+
+		public string Description { get; set; }
+	}
+}

src/SpatialFocus.EntityFrameworkCore.Extensions/EnumWithStringLookup.cs

@@ -18,8 +18,6 @@ public EnumWithStringLookup(T value)
 			Id = value;
 		}
 
-		public string Description { get; set; }
-
 		[DatabaseGenerated(DatabaseGeneratedOption.None)]
 		public T Id { get; set; }
 	}

src/SpatialFocus.EntityFrameworkCore.Extensions/EnumWithStringLookupAndDescription.cs

@@ -0,0 +1,22 @@
+// <copyright file="EnumWithStringLookupAndDescription.cs" company="Spatial Focus">
+// Copyright (c) Spatial Focus. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+// </copyright>
+
+namespace SpatialFocus.EntityFrameworkCore.Extensions
+{
+	public class EnumWithStringLookupAndDescription<T> : EnumWithStringLookup<T>
+	{
+		public EnumWithStringLookupAndDescription()
+			: base()
+		{
+		}
+
+		public EnumWithStringLookupAndDescription(T value)
+			: base(value)
+		{
+		}
+
+		public string Description { get; set; }
+	}
+}