New feature "alternate_recording" to work around tacview bug

Author: karel26

extensions/tacview/README.md

@@ -30,7 +30,7 @@ MyNode:
           tacviewRemoteControlPassword: ''      # default
           tacviewPlaybackDelay: 600             # default 0, should be 600 for performance reasons
           tacviewDataCaptureMode: 8             # As of v1.9.5: default 1, defines at which frame Tacview should update (1 = every frame, 10 = every 10th frame). 
-          target: '<id:112233445566778899>'     # optional: channel id or directory
+          target: '<id:112233445566778899>'     # Optional: channel id or directory 
 ```
 __Optional__ parameters (will change options.lua if necessary):</br>
 * **tacviewExportPath** Sets this as the Tacview export path.

extensions/tacview/extension.py

@@ -1,9 +1,12 @@
+from datetime import datetime
+
 import aiofiles
 import asyncio
 import os
 import re
 import shutil
 import sys
+import tempfile
 
 from core import Extension, utils, ServiceRegistry, Server, get_translation, InstallException, DISCORD_FILE_SIZE_LIMIT, \
     Status, PortType, Port
@@ -79,7 +82,13 @@ def __init__(self, server: Server, config: dict):
     async def startup(self, *, quiet: bool = False) -> bool:
         self.stop_event.clear()
         self.stopped.clear()
-        if self.config.get('target'):
+        if self.config.get('alternate_recording', False):
+            asyncio.create_task(
+                self.start_recording("Tacview-{}-DCS-Host-{}.acmi".format(
+                    datetime.now().strftime("%Y%m%d-%H%M%S"), utils.slugify(self.server.current_mission.name))
+                )
+            )
+        elif self.config.get('target'):
             asyncio.create_task(self.check_log())
         return await super().startup()
 
@@ -89,7 +98,10 @@ async def _shutdown(self):
 
     @override
     def shutdown(self, *, quiet: bool = False) -> bool:
-        if self.config.get('target'):
+        if self.config.get('alternate_recording', False):
+            self.loop.create_task(self.stop_recording())
+            return True
+        elif self.config.get('target'):
             self.loop.create_task(self._shutdown())
             self.stop_event.set()
             return True

extensions/tacview/recorder.py

@@ -147,10 +147,10 @@ async def _reader_loop(self) -> None:
                     chunk = await self.reader.read(65536)
                 except asyncio.IncompleteReadError:
                     # Remote closed connection
-                    self.log.warning("Connection closed by remote.")
+                    self.log.debug("Tacview connection closed by remote.")
                     break
                 if not chunk:
-                    self.log.warning("Connection closed by remote.")
+                    self.log.debug("Tacview connection closed by remote.")
                     break
                 await self._ingest(chunk)
         finally:

extensions/tacview/schemas/tacview_schema.yaml

@@ -7,6 +7,7 @@ schema;node_tacview_schema:
     installation: {type: str, nullable: false, range: {min: 1}, func: dir_exists}
     host: {type: str, nullable: false}
     show_passwords: {type: bool, nullable: false}
+    alternate_recording: {type: bool, nullable: false}
     tacviewExportPath: {type: str, nullable: false, range: {min: 1}}
     tacviewAutoDiscardFlights: {type: int, nullable: false}
     tacviewDebugMode: {type: int, nullable: false}
@@ -34,6 +35,7 @@ schema;instance_tacview_schema:
     host: {type: str, nullable: false}
     log: {type: str, nullable: false}
     show_passwords: {type: bool, nullable: false}
+    alternate_recording: {type: bool, nullable: false}
     tacviewExportPath: {type: str, nullable: false}
     tacviewAutoDiscardFlights: {type: int, nullable: false}
     tacviewDebugMode: {type: int, nullable: false}