BUGFIX:

- discord command names might differ from allowed python function names

Author: karel26

core/utils/helper.py

@@ -8,6 +8,7 @@
 import importlib
 import inspect
 import json
+import keyword
 import logging
 import luadata
 import os
@@ -79,7 +80,8 @@
     "YAMLError",
     "DictWrapper",
     "format_dict_pretty",
-    "show_dict_diff"
+    "show_dict_diff",
+    "to_valid_pyfunc_name"
 ]
 
 logger = logging.getLogger(__name__)
@@ -1170,3 +1172,29 @@ def show_dict_diff(old_dict: dict[str, Any], new_dict: dict[str, Any], context_l
     result.append("```")
 
     return '\n'.join(result)
+
+
+def to_valid_pyfunc_name(raw_name: str) -> str:
+    """
+    Convert an arbitrary name (e.g. 'test-1') into a legal Python identifier.
+
+    Rules applied (in order):
+
+    1. Replace every character that is **not** `[A-Za-z0-9_]` with an underscore.
+    2. If the resulting string starts with a digit, prepend an underscore.
+    3. If the result is a Python keyword (`def`, `class`, …), prefix it with an underscore as well.
+
+    The function returns the sanitized name; the original name is kept unchanged.
+    """
+    # 1️⃣  Replace everything that is not a word character
+    cleaned = re.sub(r'\W', '_', raw_name)
+
+    # 2️⃣  If it starts with a digit, add a leading underscore
+    if re.match(r'^\d', cleaned):
+        cleaned = '_' + cleaned
+
+    # 3️⃣  Avoid Python keywords
+    if keyword.iskeyword(cleaned):
+        cleaned = '_' + cleaned
+
+    return cleaned

plugins/commands/commands.py

@@ -330,6 +330,7 @@ def register_commands(self):
             return
 
         for name, cmd in self.locals["commands"].items():
+            sanitized_name = utils.to_valid_pyfunc_name(name)
             try:
                 checks: list = []
                 if "roles" in cmd:
@@ -343,14 +344,14 @@ def register_commands(self):
                     kw_only = self.annotated_params(params)
                     kw_as_args = ", ".join(f"{n}={n}" for n in params.keys())
                     src = f"""
-async def __{name}_callback(interaction: discord.Interaction, {kw_only}):
+async def __{sanitized_name}_callback(interaction: discord.Interaction, {kw_only}):
    await interaction.response.defer()
    await self.exec_slash_command(interaction, {kw_as_args})
                     """
                 else:
                     # no options – only interaction
                     src = f"""
-async def __{name}_callback(interaction: discord.Interaction):
+async def __{sanitized_name}_callback(interaction: discord.Interaction):
     await interaction.response.defer()
     await self.exec_slash_command(interaction)
                     """
@@ -372,7 +373,7 @@ async def __{name}_callback(interaction: discord.Interaction):
                     },
                     local_ns,
                 )
-                _callback = local_ns[f"__{name}_callback"]
+                _callback = local_ns[f"__{sanitized_name}_callback"]
                 _callback.__module__ = self.__module__
                 _callback.__discord_app_commands_guild_only__ = True
                 _callback.__discord_app_commands_contexts__ = app_commands.AppCommandContext(guild=True)
@@ -417,7 +418,7 @@ async def __{name}_callback(interaction: discord.Interaction):
                 self.log.info(f"     - Custom command /{name} added.")
 
             except Exception as ex:
-                self.log.error(f"Failed to register command `{name}`: {ex}", exc_info=True)
+                self.log.error(f"Failed to register command `{name}`: {ex}")
 
     def _unregister_commands(self):
         for name in list(self.commands.keys()):