some stability fixes and cleanups

Author: karel26

plugins/mission/README.md

@@ -58,10 +58,10 @@ DEFAULT:
 ```
 > [!NOTE]
 > DCS World can only create menus for groups. This means, that you should create groups that contain single units only,
-> especially, if you use commands that can only be called by specific roles.
+> especially if you use commands that can only be called by specific roles.
 > 
-> Roles are checked twice though: once, when the menu gets created. You should not see any command, that your role can
-> not use. A second check is done, when the command is being executed (onChatCommand only).
+> Roles are checked twice: once when the menu gets created. You should not see any command, that your role can
+> not use. A second check is done when the command is being executed (onChatCommand only).
 
 ## Configuration
 You can configure the behaviour of the mission plugin with an optional config/plugins/mission.yaml:

plugins/mission/listener.py

@@ -493,14 +493,14 @@ async def onMissionLoadEnd(self, server: Server, data: dict) -> None:
 
     async def _smooth_pause(self, server: Server, seconds: int):
         if server.current_mission:
-            # wait for the server to be initialised correctly
+            # wait for the server to be initialized correctly
             while server.status == Status.LOADING:
                 await asyncio.sleep(1)
             # now do the smooth pause
             self.log.debug(f"Smooth pausing server {server.name} after {seconds}s")
             await server.current_mission.unpause()
             await asyncio.sleep(seconds)
-            if not server.get_active_players():
+            if server.current_mission and not server.get_active_players():
                 await server.current_mission.pause()
 
     @event(name="onSimulationStart")

services/music/radios/srs.py

@@ -58,10 +58,6 @@ def _log_output(p: subprocess.Popen):
                     "-n", self.config.get('display_name', 'DCSSB MusicBox'),
                     "-i", file
                 ]
-                # TODO: temporary workaround
-                if parse(self.server.extensions['SRS'].version) == parse('2.3.3.2'):
-                    args.extend(['--unitId', '1000'])
-
                 if debug:
                     self.log.debug(f"Running {' '.join(args)}")
                 p = subprocess.Popen(args, stdout=out, stderr=err)

services/servicebus/service.py

@@ -761,7 +761,7 @@ def datagram_received(derived, data, addr):
                 server.last_seen = datetime.now(timezone.utc)
 
                 # Handle sync channels
-                if 'channel' in msg_data and msg_data['channel'].startswith('sync-'):
+                if 'channel' in msg_data and str(msg_data['channel']).startswith('sync-'):
                     if msg_data['channel'] in server.listeners:
                         f = server.listeners.get(msg_data['channel'])
                         if f and not f.done():