CHANGES:

- RW: ignore_errors added to let other extensions run if RW errors out.

Author: karel26

extensions/realweather/README.md

@@ -25,8 +25,9 @@ MyNode:
       # [...]
       extensions:
         RealWeather:
-          enabled: true   # optional to disable the extension, default: true
-          debug: true     # see outputs of RealWeather, default: false
+          enabled: true         # optional to disable the extension, default: true
+          debug: true           # see outputs of RealWeather, default: false
+          ignore_errors: true   # continue with other extensions like MizEdit, even if RW errors out
           metar:
             icao: URMM
             runway-elevation: 50

extensions/realweather/extension.py

@@ -58,7 +58,11 @@ def load_config(self) -> dict | None:
                 with open(self.config_path, mode='rb') as infile:
                     return tomli.load(infile)
         except Exception as ex:
-            raise RealWeatherException(f"Error while reading {self.config_path}: {ex}")
+            message = f"Error while reading {self.config_path}: {ex}"
+            if self.config.get('ignore_errors', False):
+                self.log.error(message)
+            else:
+                raise RealWeatherException(message)
 
     def get_config(self, filename: str) -> dict:
         if 'terrains' in self.config:
@@ -116,7 +120,11 @@ async def generate_config_1_0(self, input_mission: str, output_mission: str, ove
             with open(self.config_path, mode='r', encoding='utf-8') as infile:
                 cfg = json.load(infile)
         except json.JSONDecodeError as ex:
-            raise RealWeatherException(f"Error while reading {self.config_path}: {ex}")
+            message = f"Error while reading {self.config_path}: {ex}"
+            if self.config.get('ignore_errors', False):
+                self.log.error(message)
+            else:
+                raise RealWeatherException(message)
         config = await asyncio.to_thread(self.get_config, input_mission)
         # create proper configuration
         for name, element in cfg.items():
@@ -144,7 +152,12 @@ async def generate_config_2_0(self, input_mission: str, output_mission: str, ove
             with open(self.config_path, mode='rb') as infile:
                 cfg = tomli.load(infile)
         except tomli.TOMLDecodeError as ex:
-            raise RealWeatherException(f"Error while reading {self.config_path}: {ex}")
+            message = f"Error while reading {self.config_path}: {ex}"
+            if self.config.get('ignore_errors', False):
+                self.log.error(message)
+            else:
+                raise RealWeatherException(message)
+
         config = await asyncio.to_thread(self.get_config, input_mission)
         # create proper configuration
         for name, element in cfg.items():
@@ -213,8 +226,11 @@ def run_subprocess():
                 stdout, stderr = process.communicate()
                 if process.returncode != 0:
                     error = stdout.decode('utf-8')
-                    self.log.error(error)
-                    raise RealWeatherException(f"Error during {self.name}: {process.returncode} - {error}")
+                    message = f"Error during {self.name}: {process.returncode} - {error}"
+                    if self.config.get('ignore_errors', False):
+                        self.log.error(message)
+                    else:
+                        raise RealWeatherException(message)
                 output = stdout.decode('utf-8')
                 metar = next((x for x in output.split('\n') if 'METAR:' in x), "")
                 remarks = self.locals.get('realweather', {}).get('mission', {}).get('brief', {}).get('remarks', '')

extensions/realweather/schemas/realweather_schema.yaml

@@ -6,6 +6,7 @@ schema;node_realweather_schema:
     name: {type: str, nullable: false, range: {min: 1}}
     installation: {type: str, required: true, nullable: false, range: {min: 1}, func: dir_exists}
     autoupdate: {type: bool, nullable: false}
+    ignore_errors: {type: bool, nullable: false}
     realweather:
       type: map
       nullable: false
@@ -84,6 +85,7 @@ schema;instance_realweather_schema:
     enabled: {type: bool, nullable: false}
     name: {type: str, nullable: false, range: {min: 1}}
     debug: {type: bool, nullable: false}
+    ignore_errors: {type: bool, nullable: false}
     terrains:
       type: map
       nullable: false