debug

Author: karel26

MULTINODE.md

@@ -11,16 +11,16 @@ This is the virtual bracket around everything. Your _Guild_ ID is your Discord s
 of nodes will form a DCSServerBot cluster under this ID.
 
 - **Node**<br>
-A _Node_ is a single installation of DCSServerBot. You can run multiple nodes on one PC (see below) or you can run them
+A _Node_ is a single installation of DCSServerBot. You can run multiple nodes on one PC (see below), or you can run them
 on different PCs. Each node is a single Python process. Only one of the nodes can be a master. The cluster will 
-determine automatically, which one that is and will automatically switch the master to another node on system downtimes 
+determine automatically which one that is and will automatically switch the master to another node on system downtimes 
 or outages.
 
 If you want to run your DCSServerBot over multiple locations, you need to prepare your setup:
 
 ## Cloud-Drive Setup (default)
-You need to make sure, that every node in your cluster is aware of the full configuration. The best way to achieve this
-is to have the bot or at least the bots configuration installed on a cloud drive, like OneDrive or Google Drive. 
+You need to make sure that every node in your cluster is aware of the full configuration. The best way to achieve this
+is to have the bot or at least the bot's configuration installed on a cloud drive, like OneDrive or Google Drive. 
 I personally prefer OneDrive, as its technology is superior to Google Drive. But any cloud drive or NAS should work.
 
 Add these lines to your configuration:
@@ -83,9 +83,9 @@ where you can rent one for relatively small money.
 
 ## Running multiple versions of DCS World on one PC
 One DCSServerBot node can run as many DCS servers as your PC can handle, but they all share the very same DCS World 
-installation. This means, you can **not** run two different DCS World installations with separate root mods installed.<br>
+installation. This means you can **not** run two different DCS World installations with separate root mods installed.<br>
 To achieve this, you need to run two or more nodes on one PC.<br>
-DCSServerBot uses the hostname of the PC as node name, if not specified otherwise. To be able to run multiple nodes on
+DCSServerBot uses the hostname of the PC as a node name, if not specified otherwise. To be able to run multiple nodes on
 the same PC, you need to specify an additional parameter -n (or --node) on startup (e.g. `run -n node01`).<br>
 This will start a new node (you'll be prompted for the installation of it, if it does not exist yet), with the name
 "node01". 
@@ -95,12 +95,12 @@ This will start a new node (you'll be prompted for the installation of it, if it
 ## Running multiple Nodes on multiple PCs
 If you set up your environment with a cloud drive for your installation and a central database that is accessible from
 every node, the installation of an additional node is quite straight forward.<br>
-You just need to run `run.cmd` or `install.cmd` on your new node and the installer will guide you through your 
+You need to run `run.cmd` or `install.cmd` on your new node and the installer will guide you through your 
 installation. If not specified otherwise, the node-name will be the hostname of the respective node.
 
 > [!TIP]
-> If you use multiple nodes on multiple PCs, you might get to the moment where instances are named identical. 
-> This will start with the first instance already, if you keep the default name "DCS.release_server".<br>
+> If you use multiple nodes on multiple PCs, you might get to the moment where instances are named identically. 
+> This will start with the first instance already if you keep the default name "DCS.release_server".<br>
 > As many configuration files only use the instance name per default, you might need to add the node name as well.
 > This can be done the same as it is already in your nodes.yaml: The node can be the outer structure in each config file.
 > 
@@ -123,10 +123,10 @@ installation. If not specified otherwise, the node-name will be the hostname of
 >   DCS.release_server:
 >     some-param: C
 > ```
-DCSServerBot will understand both versions. The DEFAULT will be used for ALL instances, independent on which node they 
+DCSServerBot will understand both versions. The DEFAULT will be used for ALL instances, independent of which node they 
 are on. If you don't provide a node in a multi-node-system, the bot will read the same parameters for all instances 
 that are named DCS.release_server on any of your nodes. This can be what you want, but it can lead to errors.<br>
-I would always recommend to create the node-specific version (ex: "Multi-Node-Config" above) to avoid confusion. That's 
+I would always recommend creating the node-specific version (ex: "Multi-Node-Config" above) to avoid confusion. That's 
 what the bot will create during a default installation also.
 
 ### Moving a Server from one Node / Instance to another

core/data/impl/nodeimpl.py

@@ -518,14 +518,18 @@ async def upgrade_pending(self) -> bool:
     async def _upgrade(self, conn: psycopg.AsyncConnection):
         # We do not want to run an upgrade if we are on a cloud drive. Just restart in this case.
         if not self.master and self.locals.get('cloud_drive', True):
+            self.log.debug("Upgrade: restart agent after master upgrade.")
             await self.restart()
         elif await self.upgrade_pending():
             if self.master:
+                self.log.debug("Upgrade: set update pending to TRUE.")
                 await conn.execute("""
                     UPDATE cluster SET update_pending = TRUE WHERE guild_id = %s
                 """, (self.guild_id, ))
+            self.log.debug("Upgrade: launch update.py")
             await self.shutdown(UPDATE)
         elif self.master:
+            self.log.debug("Upgrade: reset update pending to FALSE.")
             await conn.execute("""
                UPDATE cluster
                SET update_pending = FALSE, version = %s
@@ -791,6 +795,7 @@ async def unregister(self):
     async def heartbeat(self) -> bool:
         async def handle_upgrade(master: str) -> bool:
             if master == self.name:
+                self.log.debug("Upgrade: Master => trigger agent upgrades")
                 # let all other nodes upgrade themselve
                 for node in await self.get_active_nodes():
                     data = {
@@ -807,6 +812,7 @@ async def handle_upgrade(master: str) -> bool:
                 """, (__version__, self.guild_id))
                 return True
             elif await is_node_alive(master, 300 if self.slow_system else 180): # give the master time to upgrade
+                self.log.debug("Upgrade: master => still upgrading")
                 return False
             else:
                 # the master is dead, so reset update pending

extensions/tacview/README.md

@@ -43,7 +43,7 @@ __Optional__ parameters (will change options.lua if necessary):</br>
 * **show_passwords** specifies whether to show the Tacview passwords in the server embed in your status channel or not.
 * **target** a channel or directory where your tacview files should be uploaded to on mission end.
 
-To delete old tacview files, checkout the [Cleanup](../../services/cleanup/README.md) service.
+To delete old tacview files, check out the [Cleanup](../../services/cleanup/README.md) service.
 
 > [!NOTE]
 > The tacviewDataCaptureMode parameter can take any value, but these are the recommended ones by the Tacview team:

extensions/tacview/extension.py

@@ -141,10 +141,14 @@ async def prepare(self) -> bool:
             else:
                 dirty |= self.set_option(options, name, value)
 
-        if not options['Tacview'].get('tacviewPlaybackDelay', 0):
+        if parse(self.version) < parse('1.9.5') and not options['Tacview'].get('tacviewPlaybackDelay', 0):
             self.log.warning(
                 f'  => {self.server.name}: tacviewPlaybackDelay is not set, you might see performance issues!')
-        elif options['Tacview'].get('tacviewRealTimeTelemetryEnabled', True):
+        elif int(options['Tacview'].get('tacviewDataCaptureMode', 1)) == 1:
+            self.log.warning(
+                f'  => {self.server.name}: tacviewDataCaptureMode is set to 1, you might see performance issues!')
+
+        if options['Tacview'].get('tacviewRealTimeTelemetryEnabled', True):
             self.log.warning(
                 f'  => {self.server.name}: tacviewPlaybackDelay is set, disabling real time telemetry.')
             dirty |= self.set_option(options, 'tacviewRealTimeTelemetryEnabled', False)