BUGFIX:

- DCS bug workaround added for listStartIndex handling on empty mission lists

Author: karel26

core/data/impl/serverimpl.py

@@ -296,8 +296,8 @@ def prepare(self):
         if self.settings.get('name', 'DCS Server') != self.name:
             self.settings['name'] = self.name
         # enable persistence
-        if not self.settings.get('sav_autosave', False):
-            self.settings['sav_autosave'] = True
+        if not self.settings.get('advanced', {}).get('sav_autosave', False):
+            self.settings.setdefault('advanced', {})['sav_autosave'] = True
         if 'serverSettings' in self.locals:
             for key, value in self.locals['serverSettings'].items():
                 if key == 'advanced':

plugins/mission/commands.py

@@ -690,7 +690,7 @@ async def modify(self, interaction: discord.Interaction,
             server.on_empty = dict()
             startup = False
             msg = await interaction.followup.send(_('Changing mission ...'), ephemeral=ephemeral)
-            if not server.locals.get('mission_rewrite', True) and server.status != Status.STOPPED:
+            if not server.locals.get('mission_rewrite', True) and server.status in [Status.PAUSED, Status.RUNNING]:
                 await server.stop()
                 startup = True
             filename = await server.get_current_mission_file()

plugins/mission/lua/commands.lua

@@ -260,11 +260,12 @@ function dcsbot.addMission(json)
 	end
 	net.missionlist_append(path)
 	local current_missions = net.missionlist_get()
-    local listStartIndex
+	local listStartIndex = current_missions["listStartIndex"]
     if json.autostart == true then
         listStartIndex = #current_missions['missionList']
-    else
-        listStartIndex = current_missions["listStartIndex"]
+    -- workaround DCS bug
+    elseif #current_missions['missionList'] < listStartIndex then
+        listStartIndex = 1
     end
 	utils.saveSettings({
         missionList = current_missions["missionList"],
@@ -277,9 +278,14 @@ function dcsbot.deleteMission(json)
     log.write('DCSServerBot', log.DEBUG, 'Mission: deleteMission()')
 	net.missionlist_delete(json.id)
 	local current_missions = net.missionlist_get()
+    -- workaround DCS bug
+	local listStartIndex = current_missions["listStartIndex"]
+    if #current_missions['missionList'] < listStartIndex then
+        listStartIndex = 1
+    end
 	utils.saveSettings({
 		missionList = current_missions["missionList"],
-		listStartIndex = current_missions["listStartIndex"]
+		listStartIndex = listStartIndex
 	})
 	dcsbot.listMissions(json)
 end
@@ -291,8 +297,14 @@ function dcsbot.replaceMission(json)
     net.missionlist_append(json.path)
     net.missionlist_move(#current_missions["missionList"], tonumber(json.index))
 	current_missions = net.missionlist_get()
+    -- workaround DCS bug
+	local listStartIndex = current_missions["listStartIndex"]
+    if #current_missions['missionList'] < listStartIndex then
+        listStartIndex = 1
+    end
 	utils.saveSettings({
-        missionList = current_missions["missionList"]
+		missionList = current_missions["missionList"],
+		listStartIndex = listStartIndex
     })
 	dcsbot.listMissions(json)
 end

plugins/mission/status.py

@@ -206,7 +206,8 @@ async def render(self, server: Server):
                     (server.name in listener.active_servers):
                 text += '\n\n- User statistics are enabled.'
                 break
-        if (await server.get_current_mission_file()).endswith('.sav'):
+        current_mission = await server.get_current_mission_file()
+        if current_mission and current_mission.endswith('.sav'):
             text += '\n- Mission persistence is enabled.'
         text += f'\n\nLast updated: {datetime.now(timezone.utc):%y-%m-%d %H:%M:%S UTC}'
         self.embed.set_footer(text=text)

schemas/servers_schema.yaml

@@ -54,6 +54,7 @@ schema;settings_schema:
         event_Takeoff: {type: bool, nullable: false}
         bluePasswordHash: {type: str, nullable: false, range: {min: 1}}
         redPasswordHash: {type: str, nullable: false, range: {min: 1}}
+        sav_autosave: {type: bool, nullable: false}
 
 type: map
 mapping: