CHANGES:

- Renamed OvGME => ModManager!
- Renamed Services/Scheduler to Services/Cron!

Author: karel26

ARCHITECTURE.md

@@ -41,7 +41,7 @@ Node
    |_ DashBoard
    |_ Monitoring
    |_ Backup (optional)
-   |_ OvGME (optional)
+   |_ ModManager (optional)
    |_ Music (optional)
 |_ Extensions (all optional)
    |_ DCS-SRS

README.md

@@ -38,12 +38,12 @@ Discord commands, like the Music service. Some services only run on the master n
 |------------|-----------------------------------------------------------------------------------------------------------|-------------|-------------------------------------------|
 | Backup     | Backup your bot- and DCS-configuration, your missions, database, etc.                                     | Backup      | [README](./services/backup/README.md)     |
 | Bot        | The Discord bot handling all discord commands. There is a Discord-free variant available also (see blow)! |             | [README](./services/bot/README.md)        |
-| Cleanup    | Cleanup logfiles, trackfiles, etc. from your disk.                                                        |             | [README](./services/cleanup/README.md)    |
+| Cleanup    | Cleanup log-files, track-files, etc. from your disk.                                                      |             | [README](./services/cleanup/README.md)    |
 | Dashboard  | Nice console graphics display to show the status of your bot / servers.                                   |             | [README](./services/dashboard/README.md)  |
 | Monitoring | Availability- and performance-monitoring of your DCS servers.                                             | ServerStats | [README](./services/monitoring/README.md) |
 | Music      | Play music over different SRS-radios on your servers.                                                     | Music       | [README](./services/music/README.md)      |
-| OvGME      | Manage mods that needs to be installed / updated in your DCS servers.                                     | OvGME       | [README](./services/ovgme/README.md)      |
-| Scheduler  | Schedule tasks based on a cron-like configuration.                                                        | Scheduler   | [README](./services/scheduler/README.md)  |
+| ModManager | Manage mods that needs to be installed / updated in your DCS servers.                                     | ModManager  | [README](./services/modmanager/README.md) |
+| Cron       | Schedule tasks based on a cron-like configuration.                                                        |             | [README](./services/cron/README.md)       |
 | ServiceBus | Communication hub between every node of the bot cluster and all DCS-servers.                              |             | [README](./services/servicebus/README.md) |
 
 ### Plugins
@@ -72,7 +72,7 @@ from time to time, but you as a community member can also create your own plugin
 | LotAtc       | Upload LotAtc Transponder files to your servers.                                | yes      |                         | [README](./plugins/lotatc/README.md)       |
 | MOTD         | Message for players on join or when they jump in a module.                      | yes      | Mission, MissionStats   | [README](./plugins/motd/README.md)         |
 | Music        | Upload and play music over SRS.                                                 | yes      |                         | [README](./plugins/music/README.md)        |
-| OvGME        | Install or update mods into your DCS server.                                    | yes      |                         | [README](./plugins/ovgme/README.md)        |
+| ModManager   | Install or update mods into your DCS server.                                    | yes      |                         | [README](./plugins/modmanager/README.md)   |
 | Pretense     | Commands for Pretense missions.                                                 | yes      |                         | [README](./plugins/pretense/README.md)     |
 | Punishment   | Punish users for team-hits or team-kills.                                       | yes      | Mission                 | [README](./plugins/punishment/README.md)   |
 | RealWeather  | Apply real weather to your missions (also available as an extension).           | yes      |                         | [README](./plugins/realweather/README.md)  |
@@ -107,7 +107,7 @@ DCSServerBot supports some of them already and can add a bit of quality of life.
 | LotAtc      | GCI- and ATC-extension for DCS World. Simple display only extension.                                       | [README](./extensions/lotatc/README.md)      |
 | MizEdit     | My own invention, can be used to modify your missions. Very powerful!                                      | [README](./extensions/mizedit/README.md)     |
 | Olympus     | Real-time control of your DCS missions through a map interface.                                            | [README](./extensions/olympus/README.md)     |
-| OvGME       | Use mods within your DCS World servers.                                                                    | [README](./extensions/ovgme/README.md)       |
+| ModManager  | Use mods within your DCS World servers.                                                                    | [README](./extensions/modmanager/README.md)  |
 | Pretense    | Dynamic campaign framework by Dzsek.                                                                       | [README](./extensions/pretense/README.md)    |
 | RealWeather | Real weather for your missions using DCS Real Weather.                                                     | [README](./extensions/realweather/README.md) |
 | Sneaker     | Moving map interface (see [Battleground](https://github.com/Frigondin/DCSBattleground) for another option! | [README](./extensions/sneaker/README.md)     |
@@ -306,7 +306,7 @@ opt_plugins:                          # Optional: list of optional plugins to be
 - slotblocking
 - music
 - funkman
-- ovgme
+- modmanager
 - commands
 - restapi
 ```

core/data/impl/nodeimpl.py

@@ -276,12 +276,12 @@ async def init_db(self) -> tuple[ConnectionPool, AsyncConnectionPool]:
         return db_pool, db_apool
 
     async def close_db(self):
-        if not self.pool.closed:
+        if self.pool and not self.pool.closed:
             try:
                 self.pool.close()
             except Exception as ex:
                 self.log.exception(ex)
-        if not self.apool.closed:
+        if self.apool and not self.apool.closed:
             try:
                 await self.apool.close()
             except Exception as ex:

docs/commands/index.md

@@ -104,7 +104,7 @@ These commands can be used to administrate the bot itself.
 | .modulestats / .modstats  | [@member / Player Name] [period] | all                         | DCS  | Display module and weapon statistics per module.                                                    |
 | .refuelings / .refuel     | [@member / Player Name] [period] | all                         | DCS  | Display refuelings per module.                                                                      |
 
-## Plugin OvGME
+## Plugin ModManager
 
 | Command         | Parameter                | Channel       | Role             | Description                                                                     |
 |-----------------|--------------------------|---------------|------------------|---------------------------------------------------------------------------------|

extensions/ovgme/README.md extensions/modmanager/README.mdextensions/ovgme/README.md renamed to extensions/modmanager/README.md

@@ -1,4 +1,4 @@
-# Extension "OvGME"
+# Extension "ModManager"
 This little extension checks, if you have any requiredModules in your miz file and shows them in the server status
 embed in Discord. Nice addition for your users, if you show them what to install to fly on your server.
 
@@ -11,6 +11,6 @@ MyNode:
     DCS.release_server:
       # [...]
       extensions:
-        OvGME:
+        ModManager:
           enabled: true
 ```

extensions/ovgme/__init__.py extensions/modmanager/__init__.pyextensions/ovgme/__init__.py renamed to extensions/modmanager/__init__.py

@@ -4,11 +4,11 @@
 from typing import Optional
 
 __all__ = [
-    "OvGME"
+    "ModManager"
 ]
 
 
-class OvGME(Extension):
+class ModManager(Extension):
     def __init__(self, server: Server, config: dict):
         super().__init__(server, config)
         self.modules: dict[str, list[str]] = {}

extensions/ovgme/extension.py extensions/modmanager/extension.pyextensions/ovgme/extension.py renamed to extensions/modmanager/extension.py

@@ -1,4 +1,4 @@
-schema;instance_ovgme_schema:
+schema;modmanager_schema:
   type: map
   mapping:
     enabled: {type: bool}

…tensions/ovgme/schemas/ovgme_schema.yaml …odmanager/schemas/modmanager_schema.yamlextensions/ovgme/schemas/ovgme_schema.yaml renamed to extensions/modmanager/schemas/modmanager_schema.yaml extensions/ovgme/schemas/ovgme_schema.yaml renamed to extensions/modmanager/schemas/modmanager_schema.yaml

@@ -36,8 +36,8 @@ schema;instance_extensions_schema:
       include: 'mizedit_schema'
     Olympus:
       include: 'instance_olympus_schema'
-    OvGME:
-      include: 'instance_ovgme_schema'
+    ModManager:
+      include: 'modmanager_schema'
     Pretense:
       include: 'pretense_schema'
     RealWeather: