Skip to content

fix: federated identity credential node icon BED-7696#2522

Merged
superlinkx merged 6 commits intostage/v8.9.0from
BED-7696-fix_node_icon
Mar 20, 2026
Merged

fix: federated identity credential node icon BED-7696#2522
superlinkx merged 6 commits intostage/v8.9.0from
BED-7696-fix_node_icon

Conversation

@rvazarkar
Copy link
Contributor

@rvazarkar rvazarkar commented Mar 19, 2026

Description

Fixes the node icon for federated identity credentials

Additionally fixes the following:

  • Go 1.26.1 to patch a stdlib CVE
  • Remove trivy due to second compromise

Motivation and Context

https://specterops.atlassian.net/browse/BED-7696
https://specterops.atlassian.net/browse/BED-7679
https://specterops.atlassian.net/browse/BED-7720

How Has This Been Tested?

Local testing

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Summary by CodeRabbit

  • Style

    • Added visual styling for federated identity credential nodes with icon and color support.
  • Chores

    • Updated module dependency to latest version.

@rvazarkar rvazarkar self-assigned this Mar 19, 2026
@rvazarkar rvazarkar added the bug Something isn't working label Mar 19, 2026
@rvazarkar rvazarkar changed the title Bed 7696 fix node icon fix: federated identity credential node icon Bed-7696 Mar 19, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 19, 2026

📝 Walkthrough

Walkthrough

The PR contains minimal code changes: styling additions for a node type in the graph visualization, indentation corrections across multiple database files, and a dependency version update to azurehound. No functional logic modifications or control flow changes were introduced.

Changes

Cohort / File(s) Summary
Node Styling
cmd/api/src/api/bloodhoundgraph/bloodhoundgraph.go
Added styling support for AZFederatedIdentityCredential node type: SetIcon assigns fas fa-key font icon and SetBackground sets color to #FFEE8C.
Indentation Adjustments
cmd/api/src/database/assetgrouptags.go, cmd/api/src/database/auth.go, cmd/api/src/database/customnode.go
Corrected whitespace and indentation alignment for bhdb := NewBloodhoundDB(...) variable declarations within conditional blocks. No control flow or logic changes.
Dependency Update
go.mod
Updated github.com/bloodhoundad/azurehound/v2 dependency from v2.10.1-0.20260310183647-04f79abb0ba0 to v2.11.0-rc1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive PR description covers main objectives and references Jira tickets, but lacks specific testing details and has discrepancies between stated accomplishments and actual changes. Clarify which changes are included in this PR (Go version, Trivy removal, node icon fix); provide specific testing steps and environment details; explain why some checklist items marked complete show no code changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately summarizes the main change: adding styling support (icon and background color) for the AZFederatedIdentityCredential node type, which aligns with the primary purpose described in the PR objectives.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch BED-7696-fix_node_icon

Comment @coderabbitai help to get the list of available commands and usage tips.

@rvazarkar rvazarkar changed the base branch from main to stage/v8.9.0 March 19, 2026 16:50
@rvazarkar rvazarkar changed the title fix: federated identity credential node icon Bed-7696 fix: federated identity credential node icon BED-7696 Mar 20, 2026
@superlinkx superlinkx merged commit 1d9f779 into stage/v8.9.0 Mar 20, 2026
12 checks passed
@superlinkx superlinkx deleted the BED-7696-fix_node_icon branch March 20, 2026 18:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants