Package Relocation Commits

[luke-patchblox]

Hi,

I want to start off by saying that the tool you have built is fantastic and your work on it is very much appreciated.

I was looking at the changes that are being published to standardize certain packages' folder structures and think that the new folder structure is a great design. However, I noticed that it appears that as part of the restructuring, you are deleting the old versions in a particular commit and then later adding them back in the new folder structure in a separate commit.

Because winget's publishing pipeline has a latency in committing these changes, it is highly possible that packages are no longer available until the commits for adding back the packages has been approved. Meaning, winget's package detection will be unable to recognize a package in that time span.

Would it be possible to make the changes in a single commit? In other words, both the old package deletion and package addition are done in a single commit therefore eliminating the timespan in which a package is entirely eliminated from the manifests. Or is there an inherent limitation with doing this due to their automation pipeline?

[SpecterShell]

Do you meaning moving a package to another identifier?

The winget-pkgs's validation pipeline only accepts the following types of pull requests:

1. Adding a single version for a package
2. Removing a single version for a package
3. Adding a single version and removing another version for the same package

That is to say, due to the limitation of the winget-pkgs's validation pipeline, it is impossible to add a single version for one package and remove a single version for another package within one pull request, otherwise the validation pipeline would emit an error.

[luke-patchblox]

A particular example that represents what I'm referencing is the Node.js package (OpenJS.NodeJS -> OpenJS.NodeJS.x) that is being updated now. It is both moving the package to another identifier and moving the version folders into separated major version folders.

However, it appears that there is a limitation of winget-pkgs' validation pipeline and there is not much to be done about it.

I appreciate your response and once again thanks for your work on Dumplings.