Commit 171c185
authored
Fix releases for PRs from forks
The [issue][1] was that a new release was not being created properly
when the PR came from a fork.
The fix is to trigger the release process on [`pull_request_target`][2]
rather than `pull_request`. There are some [security concerns][3] to be
aware of when using `pull_request_target`, but they are not applicable
to our use case here, as we only trigger it when the PR is closed (which
means no danger that a malicious actor could run malicious code without
it having been reviewed).
[1]: https://github.com/SpectoLabs/hoverfly-github-action/actions/runs/13983200352
[2]: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target
[3]: https://securitylab.github.com/research/github-actions-preventing-pwn-requests/1 parent 1ac9d11 commit 171c185
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
0 commit comments