Skip to content

Commit b8263d6

Browse files
authored
Use latest dependency versions in devcontainer (#78)
Prior to this commit we were pinning specific apt-get versions in the devcontainer, in order to avoid the devcontainer breaking due to a version of a dependency changing. In practice the risk of this is very small though, and the cost of using pinned apt-get versions was outweighing the perceived benefit.
1 parent e91cf57 commit b8263d6

File tree

4 files changed

+6
-57
lines changed

4 files changed

+6
-57
lines changed

.devcontainer/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,11 @@ FROM mcr.microsoft.com/vscode/devcontainers/base:${VARIANT}
88

99
ARG SHELLCHECK_VERSION="v0.7.1"
1010
SHELL ["/bin/bash", "-o", "pipefail", "-c"]
11+
# hadolint ignore=DL3008
1112
RUN apt-get update \
1213
&& export DEBIAN_FRONTEND=noninteractive \
1314
# Install xz-utils to extract tarballs
14-
&& apt-get -y install --no-install-recommends xz-utils=5.2.4-1 \
15+
&& apt-get -y install --no-install-recommends xz-utils \
1516
# Install shellcheck (apt-get doesn't install the latest version needed by VS code, so installing from GitHub release, see:
1617
# https://askubuntu.com/a/1228181)
1718
&& mkdir -p /tmp/shellcheck \

.github/DEPENDENCIES.md

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,7 @@ For major version updates, we should test that the remote container works succes
4747

4848
## Dockerfile dependencies
4949

50-
We have [pinned the linux dependencies in the devcontainer Dockerfile](https://github.com/agilepathway/hoverfly-github-action/pull/46/files), but there is no mechanism to automatically update them, currently. It looks like [it's on Dependabot's roadmap](https://github.com/dependabot/dependabot-core/issues/2129#issuecomment-511552345), so we have [an issue automatically created every 6 months](https://github.com/agilepathway/hoverfly-github-action/pull/59) to
51-
1. update the dependencies manually
52-
2. see if Dependabot now offer this functionality
53-
54-
### Updating the Dockerfile dependencies manually
55-
56-
1. Temporarily unpin the versions (i.e. remove `=<version>` from each package in the Dockerfile)
57-
2. Execute the Dockerfile (e.g. if it's a remote container Dockerfile build the remote container)
58-
3. Run `apt-cache policy <package>` for each package, to see the version installed
59-
4. Pin all the versions, replacing any old versions with new ones
50+
We do not pin the linux apt-get dependencies in the devcontainer Dockerfile as
51+
[Dependabot currently does not support this](https://github.com/dependabot/dependabot-core/issues/2129), and also the
52+
risk of side effects due to an updated apt-get dependency in the devcontainer is very small indeed (and there's zero
53+
risk to production, as this is just in the devcontainer).

.github/ISSUE_TEMPLATE/scheduled/update-dockerfile-dependencies.md

Lines changed: 0 additions & 18 deletions
This file was deleted.

.github/workflows/schedule_dockerfile_dependency_updates_issue.yml

Lines changed: 0 additions & 28 deletions
This file was deleted.

0 commit comments

Comments
 (0)