Skip to content

Commit c8ac0ea

Browse files
authored
Fix add path bug (#66)
* Fix bug where tests were not running For some reason the tests file (tests.yml) was not being picked up by GitHub Actions, meaning that the tests were not being run. Renaming the file to `test.yml` does trigger the tests, so this commit renames the file. Don't know why `tests.yml` is not picked up, maybe it's now a reserved filename by GitHub or something. * Fix add path bug GitHub [changed the functionality for adding a path][1], in response to a [security vulnerability][2]. This was a breaking change, which broke our Hoverfly GitHub Action. This commit fixes the breakage by using [the new way of adding a path][3]. [1]: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ [2]: GHSA-mfwh-5m23-j46w [3]: https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#adding-a-system-path
1 parent 27869df commit c8ac0ea

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

entrypoint.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,4 @@ echo "Installed hoverfly and hoverctl"
3131
"$CONTAINER_HOVERFLY_INSTALL_PATH/hoverfly" -version
3232
"$CONTAINER_HOVERFLY_INSTALL_PATH/hoverctl" version
3333

34-
echo "::add-path::$RUNNER_HOVERFLY_INSTALL_PATH"
34+
echo "$RUNNER_HOVERFLY_INSTALL_PATH" >> "$GITHUB_PATH"

0 commit comments

Comments
 (0)