From 58fe39608331b5bc1c4192a3a3c8a9d8145f775a Mon Sep 17 00:00:00 2001 From: John Boyes Date: Tue, 18 Mar 2025 16:09:16 +0000 Subject: [PATCH] Enable required status checks on forked PRs Prior to this commit the [status checks][1] that we need to run on pull requests were only set to run on pushes. This meant that they were not being run when a contributor submitted a PR from a fork. To fix this we now run the required status check workflows explicitly on pull requests as well as pushes. [1]: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks --- .github/workflows/reviewdog.yml | 6 ++++++ .github/workflows/test.yml | 8 +++++++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index 4190128..6ce4965 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -1,6 +1,12 @@ --- name: reviewdog on: # yamllint disable-line rule:truthy + pull_request: + types: + - opened + - edited + - reopened + - synchronize push: jobs: diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a167730..b78a088 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,8 +1,14 @@ --- name: Test on: # yamllint disable-line rule:truthy - # Run the tests on every push, and also at 3am every night + pull_request: + types: + - opened + - edited + - reopened + - synchronize push: + # Run the tests at 3am every night schedule: - cron: '0 3 * * *' # * is a special character in YAML so you have to quote this string env: