Merge pull request #490 from RachelTucker/5_0_x_API-GOSDK-29-mem-leak-fix

GOSDK-29: SDK leaks memory from unclosed HTTP response bodies

Author: rpmoore

ds3-autogen-go/src/main/java/com/spectralogic/ds3autogen/go/GoCodeGenerator.java

@@ -251,7 +251,9 @@ static ResponseModelGenerator<?> getResponseGenerator(final Ds3Request ds3Reques
      * Retrieves the appropriate template that will generate the Go response handler
      */
     private Template getResponseTemplate(final Ds3Request ds3Request) throws IOException {
-        //TODO special case if necessary
+        if (isGetObjectAmazonS3Request(ds3Request)) {
+            return config.getTemplate("response/response_get_object_template.ftl");
+        }
         return config.getTemplate("response/response_template.ftl");
     }
 

ds3-autogen-go/src/main/resources/tmpls/go/response/response_get_object_template.ftl

@@ -0,0 +1,21 @@
+type ${name} struct {
+    ${payloadStruct}
+    Headers *http.Header
+}
+
+${parseResponseMethod}
+
+func New${name}(webResponse WebResponse) (*${name}, error) {
+    expectedStatusCodes := []int { ${expectedCodes} }
+
+    switch code := webResponse.StatusCode(); code {
+    <#list responseCodes as code>
+    case ${code.code}:
+        ${code.parseResponse}
+    </#list>
+    default:
+        defer webResponse.Body().Close()
+        return nil, buildBadStatusCodeError(webResponse, expectedStatusCodes)
+    }
+}
+

ds3-autogen-go/src/main/resources/tmpls/go/response/response_template.ftl

@@ -6,6 +6,7 @@ type ${name} struct {
 ${parseResponseMethod}
 
 func New${name}(webResponse WebResponse) (*${name}, error) {
+    defer webResponse.Body().Close()
     expectedStatusCodes := []int { ${expectedCodes} }
 
     switch code := webResponse.StatusCode(); code {