Add test for max offset to not overflow buffer; fix put_bulk test regression

Author: DenverM80

src/CMakeLists.txt

@@ -9,8 +9,10 @@ add_library(ds3 SHARED
             ds3_connection.h ds3_connection.c)
 
 if (WIN32)
-    #set(WINDOWS_VS_OUTPUT_DIR ${PROJECT_SOURCE_DIR}/win32/src/Debug)
+    set(CMAKE_BUILD_TYPE Release)
     set(WINDOWS_VS_OUTPUT_DIR ${PROJECT_SOURCE_DIR}/win32/src/Release)
+    #set(CMAKE_BUILD_TYPE Debug)
+    #set(WINDOWS_VS_OUTPUT_DIR ${PROJECT_SOURCE_DIR}/win32/src/Debug)
 
     set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${WINDOWS_VS_OUTPUT_DIR})
     set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${WINDOWS_VS_OUTPUT_DIR})

src/ds3_init_requests.c

@@ -26,12 +26,7 @@
 #include "ds3_request.h"
 #include "ds3_net.h"
 
-//The max size of an uint32_t should be 10 characters + NULL
-static const char UNSIGNED_LONG_BASE_10[] = "4294967296";
-static const unsigned int UNSIGNED_LONG_BASE_10_STR_LEN = sizeof(UNSIGNED_LONG_BASE_10) + 1;
-//The max size of an uint64_t should be 20 characters + NULL
-static const char UNSIGNED_LONG_LONG_BASE_10[] = "18446744073709551615";
-static const unsigned int UNSIGNED_LONG_LONG_BASE_10_STR_LEN = sizeof(UNSIGNED_LONG_LONG_BASE_10) + 1;
+static const unsigned int STRING_BUFFER_SIZE = 32;
 
 static char* _get_ds3_bucket_acl_permission_str(ds3_bucket_acl_permission input) {
     if (input == DS3_BUCKET_ACL_PERMISSION_LIST) {
@@ -857,21 +852,21 @@ static void _set_query_param_flag(const ds3_request* _request, const char* key,
 }
 
 static void _set_query_param_uint64_t(const ds3_request* _request, const char* key, uint64_t value) {
-    char string_buffer[UNSIGNED_LONG_LONG_BASE_10_STR_LEN];
+    char string_buffer[STRING_BUFFER_SIZE];
     memset(string_buffer, 0, sizeof(string_buffer));
     snprintf(string_buffer, sizeof(string_buffer), "%" PRIu64, value);
     _set_query_param(_request, key, string_buffer);
 }
 
 static void _set_query_param_int(const ds3_request* _request, const char* key, int value) {
-    char string_buffer[UNSIGNED_LONG_BASE_10_STR_LEN];
+    char string_buffer[STRING_BUFFER_SIZE];
     memset(string_buffer, 0, sizeof(string_buffer));
     snprintf(string_buffer, sizeof(string_buffer), "%d", value);
     _set_query_param(_request, key, string_buffer);
 }
 
 static void _set_query_param_float(const ds3_request* _request, const char* key, float value) {
-    char string_buffer[UNSIGNED_LONG_BASE_10_STR_LEN];
+    char string_buffer[STRING_BUFFER_SIZE];
     memset(string_buffer, 0, sizeof(string_buffer));
     snprintf(string_buffer, sizeof(string_buffer), "%f", value);
     _set_query_param(_request, key, string_buffer);

test/bucket_tests.cpp

@@ -15,9 +15,23 @@
 
 #include <stdio.h>
 #include "ds3.h"
+#include "ds3_request.h"
 #include "test.h"
 #include <boost/test/unit_test.hpp>
 #include <glib.h>
+#include <limits.h>
+
+BOOST_AUTO_TEST_CASE( init_put_object_offset_unsigned_long_long ) {
+    printf("-----Testing init PUT_OBJECT with max unsigned long long offset-------\n");
+
+    struct _ds3_request* request = ds3_init_put_object_request("Test_bucket", "test_object", 1024 * 1024);
+    ds3_request_set_offset(request, ULLONG_MAX);
+
+    char* value = (char*)g_hash_table_lookup(request->query_params, "offset");
+    printf("  request->query_params[\"offset\"]:%s\n", value);
+    BOOST_CHECK(value != NULL);
+    BOOST_CHECK(g_strcmp0(value, "18446744073709551615") == 0);
+}
 
 BOOST_AUTO_TEST_CASE( bulk_put ) {
     printf("-----Testing Bulk PUT-------\n");
@@ -63,15 +77,15 @@ BOOST_AUTO_TEST_CASE( empty_folder ) {
     const char* objects[1] = {"empty-folder/"};
     ds3_bulk_object_list_response* object_list = ds3_convert_object_list_from_strings(objects, 1);
     ds3_request* request = ds3_init_put_bulk_job_spectra_s3_request(bucket_name, object_list);
-    ds3_master_object_list_response* bulk_response = NULL;
+    ds3_master_object_list_response* bulk_response;
     error = ds3_put_bulk_job_spectra_s3_request(client, request, &bulk_response);
     handle_error(error);
-    ds3_master_object_list_response_free(bulk_response);
 
     request = ds3_init_put_object_request(bucket_name, objects[0], 0);
     ds3_request_set_job(request, bulk_response->job_id->value);
-    error   = ds3_put_object_request(client, request, NULL, NULL);
+    error = ds3_put_object_request(client, request, NULL, NULL);
     ds3_request_free(request);
+    ds3_master_object_list_response_free(bulk_response);
     handle_error(error);
 
     ds3_list_bucket_result_response* response;