Skip to content

Commit 91542d3

Browse files
committed
Merge pull request #12 from robertgrimm/master
Change s3_request_set_max_key's max_keys argument and fix a few format warnings
2 parents db5adf2 + c0f4c30 commit 91542d3

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

src/ds3.c

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,7 @@ static ds3_error* _net_process_request(const ds3_client* client, const ds3_reque
461461
return error;
462462
}
463463

464-
fprintf(stderr, "Got status code of (%ld) expected (%ld)\n", response_data.status_code, request->expected_status_code);
464+
fprintf(stderr, "Got status code of (%llu) expected (%llu)\n", response_data.status_code, request->expected_status_code);
465465
if(request->expected_status_code != response_data.status_code) {
466466
ds3_error* error = _ds3_create_error(DS3_ERROR_BAD_STATUS_CODE, "Got an unexpected status code.");
467467
error->error = g_new0(ds3_error_response, 1);
@@ -551,8 +551,11 @@ void ds3_request_set_marker(ds3_request* _request, const char* marker) {
551551
_set_query_param(_request, "marker", marker);
552552
}
553553

554-
void ds3_request_set_max_keys(ds3_request* _request, const char* max_keys) {
555-
_set_query_param(_request, "max-keys", max_keys);
554+
void ds3_request_set_max_keys(ds3_request* _request, uint32_t max_keys) {
555+
char max_keys_s[11];
556+
memset(max_keys_s, 0, sizeof(char) * 11);
557+
g_snprintf(max_keys_s, sizeof(char) * 11, "%u", max_keys);
558+
_set_query_param(_request, "max-keys", max_keys_s);
556559
}
557560

558561
static struct _ds3_request* _common_request_init(void){
@@ -1226,7 +1229,7 @@ static xmlDocPtr _generate_xml_objects_list(const ds3_bulk_object_list* obj_list
12261229
memset(size_buff, 0, sizeof(char) * 21);
12271230

12281231
obj = obj_list->list[i];
1229-
g_snprintf(size_buff, sizeof(char) * 21, "%ld", obj.length);
1232+
g_snprintf(size_buff, sizeof(char) * 21, "%llu", obj.length);
12301233

12311234
object_node = xmlNewNode(NULL, (xmlChar*) "Object");
12321235
xmlAddChild(objects_node, object_node);

src/ds3.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ LIBRARY_API void ds3_client_proxy(ds3_client* client, const char* proxy);
195195
LIBRARY_API void ds3_request_set_prefix(ds3_request* request, const char* prefix);
196196
LIBRARY_API void ds3_request_set_delimiter(ds3_request* request, const char* delimiter);
197197
LIBRARY_API void ds3_request_set_marker(ds3_request* request, const char* marker);
198-
LIBRARY_API void ds3_request_set_max_keys(ds3_request* request, const char* max_keys);
198+
LIBRARY_API void ds3_request_set_max_keys(ds3_request* request, uint32_t max_keys);
199199

200200
LIBRARY_API ds3_error* ds3_get_service(const ds3_client* client, const ds3_request* request, ds3_get_service_response** response);
201201
LIBRARY_API ds3_error* ds3_get_bucket(const ds3_client* client, const ds3_request* request, ds3_get_bucket_response** response);

0 commit comments

Comments
 (0)