GOSDK-18: Add object error and completed listeners to Strategies in helpers. Removing null pointer scenario from helpers with new error handling. Was trying to access variable from an item that would be null during error checking.

Author: RachelTucker

helpers/getProducer.go

@@ -204,8 +204,8 @@ func (producer *getProducer) processWaitingBlobs(bucketName string, jobId string
         producer.Debugf("attempting to process '%s' offset=%d length=%d", curBlob.Name(), curBlob.Offset(), curBlob.Length())
         if err != nil {
             //should not be possible to get here
-            producer.strategy.Listeners.Errored(curBlob.Name(), err)
             producer.Errorf("failure during blob transfer '%s' at offset %d: %s", curBlob.Name(), curBlob.Offset(), err.Error())
+            break
         }
         producer.queueBlobForTransfer(curBlob, bucketName, jobId)
     }

helpers/putProducer.go

@@ -142,9 +142,9 @@ func (producer *putProducer) processWaitingBlobs(bucketName string, jobId string
         //attempt transfer
         curBlob, err := producer.deferredBlobQueue.Pop()
         if err != nil {
-            producer.strategy.Listeners.Errored(curBlob.Name(), err)
+            //should not be possible to get here
             producer.Errorf("problem when getting next blob to be transferred: %s", err.Error())
-            continue
+            break
         }
         producer.Debugf("attempting to process %s offset=%d length=%d", curBlob.Name(), curBlob.Offset(), curBlob.Length())
         producer.queueBlobForTransfer(curBlob, bucketName, jobId)