Skip to content

Commit fc0c744

Browse files
RachelTuckerrpmoore
authored andcommitted
GOSDK-25: Unmarshaling optional enums in response payloads causes panic (#83)
* GOSDK-25: Unmarshaling optional enums in response payloads causes panic. Instantiating optional enums in restore payloads before assigning value. * removing test dependency on core go * GOSDK-25: Unmarshaling optional enums in response payloads causes panic. Using a constructor to create nullable enums to get around problem of preserving nil when nothing is specified.
1 parent 4e22fa1 commit fc0c744

File tree

4 files changed

+607
-14
lines changed

4 files changed

+607
-14
lines changed

ds3/ds3Client_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1916,11 +1916,11 @@ func TestVerifyPhysicalPlacementForObjectsWithFullDetailsSpectraS3(t *testing.T)
19161916
ds3Testing.AssertStringPtrIsNil(t, "PartiallyVerifiedEndOfTape", tape.PartiallyVerifiedEndOfTape)
19171917
ds3Testing.AssertNonNilStringPtr(t, "PartitionId", "dc681797-927a-4eb0-9652-d19d06534e50", tape.PartitionId)
19181918
if tape.PreviousState != nil {
1919-
t.Fatalf("Expeted previous state to be 'nil' but was '%s'.", tape.PreviousState.String())
1919+
t.Fatalf("Expeted previous state to be 'nil' but was '%v'.", tape.PreviousState)
19201920
}
19211921
ds3Testing.AssertStringPtrIsNil(t, "SerialNumber", tape.SerialNumber)
19221922
if tape.State != models.TAPE_STATE_PENDING_INSPECTION {
1923-
t.Fatalf("Expected tape state 'TAPE_STATE_PENDING_INSPECTION' but got '%s'.", tape.State.String())
1923+
t.Fatalf("Expected tape state 'TAPE_STATE_PENDING_INSPECTION' but got '%v'.", tape.State)
19241924
}
19251925
ds3Testing.AssertStringPtrIsNil(t, "StorageDomainId", tape.StorageDomainMemberId)
19261926
ds3Testing.AssertBool(t, "TakeOwnershipPending", false, tape.TakeOwnershipPending)

0 commit comments

Comments
 (0)