Skip to content

Commit 1a45734

Browse files
committed
Changed a public interface that should not have been changed
1 parent 7e24aee commit 1a45734

File tree

3 files changed

+9
-16
lines changed

3 files changed

+9
-16
lines changed

ds3-sdk/src/main/java/com/spectralogic/ds3client/helpers/MetadataReceivedListener.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717

1818
import com.spectralogic.ds3client.networking.Metadata;
1919

20-
import java.io.IOException;
21-
2220
public interface MetadataReceivedListener {
23-
void metadataReceived(final String filename, final Metadata metadata) throws IOException, InterruptedException;
21+
void metadataReceived(final String filename, final Metadata metadata);
2422
}

ds3-sdk/src/main/java/com/spectralogic/ds3client/helpers/ReadJobImpl.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -292,16 +292,7 @@ private void sendMetadataEvents(final String objName , final Metadata metadata)
292292
getEventRunner().emitEvent(new Runnable() {
293293
@Override
294294
public void run() {
295-
try {
296-
listener.metadataReceived(objName, metadata);
297-
} catch (final IOException | InterruptedException e) {
298-
emitFailureEvent(FailureEvent.builder()
299-
.doingWhat(FailureEvent.FailureActivity.GettingObject)
300-
.withCausalException(e)
301-
.withObjectNamed(objName)
302-
.usingSystemWithEndpoint(client.getConnectionDetails().getEndpoint())
303-
.build());
304-
}
295+
listener.metadataReceived(objName, metadata);
305296
}
306297
});
307298
}

ds3-sdk/src/main/java/com/spectralogic/ds3client/metadata/MetadataReceivedListenerImpl.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,13 @@ public MetadataReceivedListenerImpl(final String localFilePath) {
2929
}
3030

3131
@Override
32-
public void metadataReceived(final String filename, final Metadata metadata) throws IOException, InterruptedException {
33-
final String actualFilePath = MetaDataUtil.getRealFilePath(localFilePath, filename);
34-
restoreMetaData(actualFilePath, metadata);
32+
public void metadataReceived(final String filename, final Metadata metadata) {
33+
try {
34+
final String actualFilePath = MetaDataUtil.getRealFilePath(localFilePath, filename);
35+
restoreMetaData(actualFilePath, metadata);
36+
} catch (final IOException | InterruptedException e) {
37+
throw new RuntimeException("Error restoring metadata.", e);
38+
}
3539
}
3640

3741
/**

0 commit comments

Comments
 (0)