Skip to content

Commit 39a43e5

Browse files
committed
Minor change, lets us toggle between 3.x and 4.x easier
1 parent c1fc879 commit 39a43e5

File tree

2 files changed

+18
-14
lines changed

2 files changed

+18
-14
lines changed

ds3-sdk-integration/src/test/java/com/spectralogic/ds3client/integration/UsersAndGroups_Test.java

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ public class UsersAndGroups_Test {
4747
private static final Ds3ClientHelpers HELPERS = Ds3ClientHelpers.wrap(client);
4848
private static final String BUCKET_NAME = "Users_And_Groups_Test";
4949
private static final String TEST_ENV_NAME = "UsersAndGroups_Test";
50+
private static final String USER_ID = "spectra";
51+
// private static final String USER_ID = "Administrator";
5052
private static TempStorageIds envStorageIds;
5153
private static UUID spectraUUID;
5254
private static UUID administratorsUUID;
@@ -75,7 +77,7 @@ private static void setupBucket(final UUID dataPolicy) {
7577
try {
7678
HELPERS.ensureBucketExists(BUCKET_NAME, dataPolicy);
7779
spectraUUID = client.getUserSpectraS3(
78-
new GetUserSpectraS3Request("spectra")).getSpectraUserResult().getId();
80+
new GetUserSpectraS3Request(USER_ID)).getSpectraUserResult().getId();
7981
administratorsUUID = client.getGroupSpectraS3(
8082
new GetGroupSpectraS3Request("Administrators")).getGroupResult().getId();
8183
} catch (final Exception e) {
@@ -89,16 +91,16 @@ public void getUserWithUUID() throws IOException, SignatureException {
8991
final GetUserSpectraS3Response getSpectraResponse = client
9092
.getUserSpectraS3(new GetUserSpectraS3Request(spectraUUID));
9193

92-
assertThat(getSpectraResponse.getSpectraUserResult().getName(), is("spectra"));
94+
assertThat(getSpectraResponse.getSpectraUserResult().getName(), is(USER_ID));
9395
}
9496

9597
@Test
9698
public void getUserWithString() throws IOException, SignatureException {
9799

98100
final GetUserSpectraS3Response getSpectraResponse = client
99-
.getUserSpectraS3(new GetUserSpectraS3Request("spectra"));
101+
.getUserSpectraS3(new GetUserSpectraS3Request(USER_ID));
100102

101-
assertThat(getSpectraResponse.getSpectraUserResult().getName(), is("spectra"));
103+
assertThat(getSpectraResponse.getSpectraUserResult().getName(), is(USER_ID));
102104
}
103105

104106
@Test
@@ -114,7 +116,7 @@ public void getUsers() throws IOException, SignatureException {
114116
public void getUsersWithName() throws IOException, SignatureException {
115117

116118
final GetUsersSpectraS3Response getUsersResponse = client.getUsersSpectraS3(
117-
new GetUsersSpectraS3Request().withName("spectra"));
119+
new GetUsersSpectraS3Request().withName(USER_ID));
118120

119121
assertThat(getUsersResponse.getSpectraUserListResult(), is(notNullValue()));
120122
}
@@ -467,7 +469,7 @@ public void getUserGroupMembersWithMemberUserIDString() throws IOException, Sign
467469

468470
final GetGroupMembersSpectraS3Response getGroupMembersSpectraS3Response = client
469471
.getGroupMembersSpectraS3(new GetGroupMembersSpectraS3Request()
470-
.withMemberUserId("spectra"));
472+
.withMemberUserId(USER_ID));
471473

472474
assertThat(getGroupMembersSpectraS3Response.getGroupMemberListResult(), is(notNullValue()));
473475
}
@@ -612,7 +614,7 @@ public void putUserGroupMember() throws IOException, SignatureException {
612614
new PutGroupSpectraS3Request("test_group"));
613615

614616
putUserGroupMemberSpectraS3Response = client
615-
.putUserGroupMemberSpectraS3(new PutUserGroupMemberSpectraS3Request("test_group", "spectra"));
617+
.putUserGroupMemberSpectraS3(new PutUserGroupMemberSpectraS3Request("test_group", USER_ID));
616618

617619
assertThat(putUserGroupMemberSpectraS3Response.getGroupMemberResult(), is(notNullValue()));
618620

@@ -688,7 +690,7 @@ public void putGlobalBucketAclForUserString() throws IOException, SignatureExcep
688690
try {
689691
putGlobalBucketAclForUserSpectraS3Response = client.putGlobalBucketAclForUserSpectraS3(
690692
new PutGlobalBucketAclForUserSpectraS3Request(BucketAclPermission.DELETE,
691-
"spectra"));
693+
USER_ID));
692694

693695
assertThat(putGlobalBucketAclForUserSpectraS3Response.getBucketAclResult(), is(notNullValue()));
694696

@@ -789,7 +791,7 @@ public void getBucketAclsWithUserUUID() throws IOException, SignatureException {
789791
@Test
790792
public void getBucketAclsWithUserIDString() throws IOException, SignatureException {
791793
final GetBucketAclsSpectraS3Response getBucketAclsSpectraS3Response = client
792-
.getBucketAclsSpectraS3(new GetBucketAclsSpectraS3Request().withUserId("spectra"));
794+
.getBucketAclsSpectraS3(new GetBucketAclsSpectraS3Request().withUserId(USER_ID));
793795

794796
assertThat(getBucketAclsSpectraS3Response.getBucketAclListResult(), is(notNullValue()));
795797
}
@@ -912,7 +914,7 @@ public void putGlobalDataPolicyAclForUserString() throws IOException, SignatureE
912914
PutGlobalDataPolicyAclForUserSpectraS3Response putGlobalDataPolicyAclForUserSpectraS3Response = null;
913915
try {
914916
putGlobalDataPolicyAclForUserSpectraS3Response = client.putGlobalDataPolicyAclForUserSpectraS3(
915-
new PutGlobalDataPolicyAclForUserSpectraS3Request("spectra"));
917+
new PutGlobalDataPolicyAclForUserSpectraS3Request(USER_ID));
916918

917919
assertThat(putGlobalDataPolicyAclForUserSpectraS3Response.getDataPolicyAclResult(), is(notNullValue()));
918920

@@ -971,7 +973,7 @@ public void deleteDataPolicyAcl() throws IOException, SignatureException {
971973
= null;
972974
try {
973975
putGlobalDataPolicyAclForUserSpectraS3Response = client.putGlobalDataPolicyAclForUserSpectraS3(
974-
new PutGlobalDataPolicyAclForUserSpectraS3Request("spectra"));
976+
new PutGlobalDataPolicyAclForUserSpectraS3Request(USER_ID));
975977

976978
final DeleteDataPolicyAclSpectraS3Response deleteDataPolicyAclSpectraS3Response = client
977979
.deleteDataPolicyAclSpectraS3(new DeleteDataPolicyAclSpectraS3Request(
@@ -998,7 +1000,7 @@ public void getDataPolicyAcl() throws IOException, SignatureException {
9981000
try {
9991001
putGlobalDataPolicyAclForUserSpectraS3Response = client
10001002
.putGlobalDataPolicyAclForUserSpectraS3(
1001-
new PutGlobalDataPolicyAclForUserSpectraS3Request("spectra"));
1003+
new PutGlobalDataPolicyAclForUserSpectraS3Request(USER_ID));
10021004

10031005
final GetDataPolicyAclSpectraS3Response getDataPolicyAclSpectraS3Response = client
10041006
.getDataPolicyAclSpectraS3(new GetDataPolicyAclSpectraS3Request(
@@ -1114,7 +1116,7 @@ public void getDataPolicyAclsWithUserString() throws IOException, SignatureExcep
11141116

11151117
final GetDataPolicyAclsSpectraS3Response getDataPolicyAclsSpectraS3Response = client
11161118
.getDataPolicyAclsSpectraS3(new GetDataPolicyAclsSpectraS3Request()
1117-
.withUserId("spectra"));
1119+
.withUserId(USER_ID));
11181120

11191121
assertThat(getDataPolicyAclsSpectraS3Response.getDataPolicyAclListResult(), is(notNullValue()));
11201122
}

ds3-sdk-integration/src/test/java/com/spectralogic/ds3client/integration/test/helpers/TempStorageUtil.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ public final class TempStorageUtil {
3535
private static final String DATA_POLICY_NAME = "_dp";
3636
private static final String STORAGE_DOMAIN_NAME = "_sd";
3737
private static final String POOL_PARTITION_NAME = "_pp";
38+
// private static final String USER_ID = "Administrator";
39+
private static final String USER_ID = "spectra";
3840

3941
/**
4042
* Sets up a temporary data policy with a temporary storage domain and partition
@@ -102,7 +104,7 @@ public static UUID setupDataPolicy(
102104
new PutDataPolicySpectraS3Request(testSetName + DATA_POLICY_NAME)
103105
.withEndToEndCrcRequired(withEndToEndCrcRequired)
104106
.withChecksumType(checksumType).withAlwaysForcePutJobCreation(true));
105-
client.modifyUserSpectraS3(new ModifyUserSpectraS3Request("spectra")
107+
client.modifyUserSpectraS3(new ModifyUserSpectraS3Request(USER_ID)
106108
.withDefaultDataPolicyId(dataPolicyResponse.getDataPolicyResult().getId()));
107109
return dataPolicyResponse.getDataPolicyResult().getId();
108110
}

0 commit comments

Comments
 (0)