Addressing code review comments

Author: GraciesPadre

ds3-sdk/src/main/java/com/spectralogic/ds3client/helpers/FileSystemHelperImpl.java

@@ -77,32 +77,35 @@ public ObjectStorageSpaceVerificationResult objectsFromBucketWillFitInDirectory(
 
         long requiredSpace = 0;
         long availableSpace = 0;
-        final IOException ioException = null;
 
         if ( ! pathObjectExists(destinationDirectory)) {
+            final IOException ioException = null;
             return new ObjectStorageSpaceVerificationResult(ObjectStorageSpaceVerificationResult.VerificationStatus.PathDoesNotExist,
                     requiredSpace, availableSpace, ioException);
         }
 
         if ( ! pathIsDirectory(destinationDirectory)) {
+            final IOException ioException = null;
             return new ObjectStorageSpaceVerificationResult(ObjectStorageSpaceVerificationResult.VerificationStatus.PathIsNotADirectory,
                     requiredSpace, availableSpace, ioException);
         }
 
         if ( ! pathIsWritable(destinationDirectory)) {
+            final IOException ioException = null;
             return new ObjectStorageSpaceVerificationResult(ObjectStorageSpaceVerificationResult.VerificationStatus.PathLacksAccess,
                     requiredSpace, availableSpace, ioException);
         }
 
         try {
             helpers.ensureBucketExists(bucketName);
         } catch (final IOException e) {
+            final IOException ioException = null;
             return new ObjectStorageSpaceVerificationResult(ObjectStorageSpaceVerificationResult.VerificationStatus.BucketDoesNotExist,
                     requiredSpace, availableSpace, ioException);
         }
 
         try {
-            requiredSpace = getRequiredSpaceForObjects(getObjectSizes(helpers, bucketName, objectNames));
+            requiredSpace = getRequiredSpaceForObjects(helpers, bucketName, objectNames);
             availableSpace = getAvailableFileSpace(destinationDirectory);
         } catch (final IOException e) {
             return new ObjectStorageSpaceVerificationResult(ObjectStorageSpaceVerificationResult.VerificationStatus.CaughtIOException,
@@ -112,14 +115,17 @@ public ObjectStorageSpaceVerificationResult objectsFromBucketWillFitInDirectory(
         final ObjectStorageSpaceVerificationResult.VerificationStatus verificationStatus = availableSpace > requiredSpace ?
                 ObjectStorageSpaceVerificationResult.VerificationStatus.OK : ObjectStorageSpaceVerificationResult.VerificationStatus.PathLacksSufficientStorageSpace;
 
+        final IOException ioException = null;
         return new ObjectStorageSpaceVerificationResult(verificationStatus, requiredSpace, availableSpace, ioException);
     }
 
-    private Map<String, Long> getObjectSizes(final Ds3ClientHelpers helpers,
-                                             final String bucketName,
-                                             final Collection<String> objectNames)
-                                             throws IOException
+    private long getRequiredSpaceForObjects(final Ds3ClientHelpers helpers,
+                                            final String bucketName,
+                                            final Collection<String> objectNames)
+                                            throws IOException
     {
+        long result = 0;
+
         final Map<String, Long> objectSizeMap = new HashMap<>();
 
         final Iterable<Contents> bucketContents = helpers.listObjects(bucketName);
@@ -128,14 +134,9 @@ private Map<String, Long> getObjectSizes(final Ds3ClientHelpers helpers,
             objectSizeMap.put(bucketContent.getKey(), bucketContent.getSize());
         }
 
+        // Of the objects in the bucket, keep the information about only those in objectNames
         objectSizeMap.keySet().retainAll(objectNames);
 
-        return objectSizeMap;
-    }
-
-    private long getRequiredSpaceForObjects(final Map<String, Long> objectSizeMap) {
-        long result = 0;
-
         for (final long objectSize : objectSizeMap.values()) {
             result += objectSize;
         }

ds3-sdk/src/main/java/com/spectralogic/ds3client/helpers/UnrecoverableIOException.java

@@ -17,6 +17,14 @@
 
 import java.io.IOException;
 
+/**
+ * An UnrecoverableIOException is used to classify IOExceptions into one of 2 types:
+ * those that should result in retrying a data transfer, such as a failure in an HTTP GET or PUT;
+ * and those that should <b>not</b> result in retrying a data transfer, such as a failure writing to
+ * or reading from a file.  During an HTTP PUT or GET that involves transferring data to or from
+ * a file, file system failures are considered non-recoverable, where network-related failures
+ * are considered recoverable.
+ */
 public class UnrecoverableIOException extends IOException {
     public UnrecoverableIOException() {
         super();