Changed how the default content list gets created in the ListBucketResult so that it does not create a new list every time.

Author: rpmoore

src/main/java/com/spectralogic/ds3client/models/ListBucketResult.java

@@ -42,7 +42,7 @@ public class ListBucketResult {
 
     @JsonProperty("Contents")
     @JacksonXmlElementWrapper(useWrapping = false)
-    private List<Contents> contentsList;
+    private List<Contents> contentsList = new ArrayList<>();
 
     public String getName() {
         return name;
@@ -85,7 +85,7 @@ public void setTruncated(final boolean isTruncated) {
     }
 
     public List<Contents> getContentsList() {
-        return contentsList == null ? new ArrayList<Contents>() : contentsList;
+        return contentsList;
     }
 
     public void setContentsList(final List<Contents> contentsList) {

src/test/java/com/spectralogic/ds3client/serializer/XmlOutput_Test.java

@@ -19,7 +19,6 @@
 import com.spectralogic.ds3client.models.ListBucketResult;
 import com.spectralogic.ds3client.models.MasterObjectList;
 import com.spectralogic.ds3client.models.Objects;
-import com.spectralogic.ds3client.serializer.XmlOutput;
 import org.junit.Test;
 
 import java.io.IOException;
@@ -55,4 +54,13 @@ public void bucketList() throws IOException {
         assertThat(result.getContentsList().size(), is(3));
         assertThat(result.getContentsList().get(0).getSize(), is(674570l));
     }
+
+    @Test
+    public void bucketListWithEmptyContents() throws IOException {
+        final String xmlResponse = "<ListBucketResult xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\"><Name>remoteTest16</Name><Prefix/><Marker/><MaxKeys>1000</MaxKeys><IsTruncated>false</IsTruncated></ListBucketResult>";
+
+        final ListBucketResult result = XmlOutput.fromXml(xmlResponse, ListBucketResult.class);
+        assertThat(result, is(notNullValue()));
+        assertThat(result.getContentsList(), is(notNullValue()));
+    }
 }