Skip to content

Commit 3f57457

Browse files
committed
Fix test and NP1110
1 parent 1e3182a commit 3f57457

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

imec/NP1110/NP1110.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@
66
"ndim": 2,
77
"si_units": "um",
88
"annotations": {
9-
"model_name": "Neuropixels Ultra (16 banks)",
10-
"manufacturer": "IMEC",
9+
"model_name": "NP1110",
10+
"description": "Neuropixels Ultra (16 banks)",
11+
"manufacturer": "imec",
1112
"shank_tips": [
1213
[
1314
21,

tests.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,11 @@ def test_naming_convention(file):
2424
"""Check that model_name and manufacturer are lowercase. and they correspond to the path."""
2525
with open(file) as f:
2626
data = json.load(f)
27-
model_name = data["annotations"]["model_name"]
28-
manufacturer = data["annotations"]["manufacturer"]
27+
probe_annotations = data["probes"][0]["annotations"]
28+
model_name = probe_annotations["model_name"]
29+
manufacturer = probe_annotations["manufacturer"]
2930
assert manufacturer == manufacturer.lower()
3031
path_parts = file.split("/")
3132
assert model_name == path_parts[-1].replace(".json", "")
32-
assert manufacturer == path_parts[-2]
33+
assert model_name == path_parts[-2]
34+
assert manufacturer == path_parts[-3]

0 commit comments

Comments
 (0)