Skip to content

Commit 18b080d

Browse files
committed
Test: combinato runs but fails with toy data
1 parent edecfc9 commit 18b080d

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

combinato/Dockerfile

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ LABEL maintainer="Vincent Prevosto <[email protected]>"
55
# Ubuntu package installs
66
RUN apt update && \
77
apt install -y --no-install-recommends \
8-
git && \
8+
git \
9+
nano && \
910
apt clean && \
1011
rm -rf /var/lib/apt/lists/*
1112

@@ -27,10 +28,10 @@ RUN git clone https://github.com/jniediek/combinato.git
2728
ENV COMBINATO_DIR /src/combinato
2829
ENV PATH=$PATH:$COMBINATO_DIR
2930
ENV PYTHONPATH=$PYTHONPATH:/usr/local/bin/python3:$COMBINATO_DIR
30-
RUN echo $' \n\
31-
PATH=$PATH:/src/combinato \n\
32-
PYTHONPATH=$PYTHONPATH:/usr/local/bin/python3:$COMBINATO_DIR \n\
33-
export PATH PYTHONPATH ' >> /root/.bashrc
31+
RUN echo '\n\
32+
export PATH=$PATH:/src/combinato\n\
33+
export PYTHONPATH=$PYTHONPATH:/usr/local/bin/python3:/src/combinato\n\
34+
export COMBINATO_PATH=/src/combinato' >> /root/.bashrc
3435

3536
# Install Combinato
3637
WORKDIR /src/combinato

combinato/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@ Build default image:
33
docker build -t combinato:latest .
44

55
### Run container in bash
6-
docker run --rm -it -v <host-data-folder>:<docker-data-folder> spikeinterface/combinato /bin/sh
6+
docker run --rm -it -v <host-data-folder>:<docker-data-folder> spikeinterface/combinato-base /bin/sh
77
flags:
88
--rm: removes container once it's stopped
99
-it: for interactive session
1010
-v: mounted volumes (directories)
1111

1212
### Test
13+
docker run --rm -it spikeinterface/combinato-base /bin/sh
1314
python3 tools/test_installation.py

0 commit comments

Comments
 (0)