Skip to content

Conversation

@chrishalcrow
Copy link
Member

@chrishalcrow chrishalcrow commented Jan 7, 2026

Allows the user to apply the current curation to the analyzer, creating a new analyzer in memory.

What this PR does:

  • When the user clicks the apply_curation button, we create a new, curated analyzer in memory. All views are _reinitialized and the CurationModel is created and stored in controller.applied_curations and the current curation is cleared. Now the user can start curating again.
  • Adds _reinitialize method to all Views, allowing the view to update when the analyzer is updated (might also be useful for re-computations!)
  • Allows the user to save multiple curations as a SequentialCuration.

I think this is pretty much done!

To do:

  • add to panel
  • save original analyzer without extensions somewhere
  • keep track of the chain of curations (must add new_unit_ids)
  • ensure properties are properly kept track of
  • ensure colours are properly kept track of
  • be able to save multiple curations
  • allow user to undo apply(??)

@samuelgarcia
Copy link
Member

Clearly I totaly I lost the control here.
My only wish now is that this will be an optional (and maybe hidden) feature that will be false by default.

@chrishalcrow
Copy link
Member Author

Haha, I don't think so Sam! The core logic has changed much - most of the gross code is related to storing the chain of curations and being able to save them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants