Valid unit periods extension #4299
Conversation
|
Depends on #4302 |
for more information, see https://pre-commit.ci
| "amplitude_scalings", | ||
| ), "Invalid amplitude_extension. It can be either 'spike_amplitudes' or 'amplitude_scalings'" | ||
| sorting = sorting_analyzer.sorting | ||
| total_duration = sorting_analyzer.get_total_duration() |
There was a problem hiding this comment.
Hello - do we need to be careful about stuff like this? Here the total_duration of the entire recording. It's used later to compute a firing rate, and this firing rate is the total num spikes divided by total duration, rather than num-spike-in-periods/duration-of-periods.
There was a problem hiding this comment.
In this case is the num spikes in period. So I think this is correct, but I'll double check carefully!
There was a problem hiding this comment.
In this case is the num spikes in period. So I think this is correct, but I'll double check carefully!
There was a problem hiding this comment.
I don't understand. In this case, it should be num spike in the period? Then I think the code is incorrect: Num spikes are computed using count_num_spikes_per_unit, which is computed using the full recording time.
There was a problem hiding this comment.
Ah it's the CV metrics! you are right, I'll take a closer look and push some fixes
Co-authored-by: Chris Halcrow <[email protected]>
Co-authored-by: Chris Halcrow <[email protected]>
…select_sorting_periods_core
4 participants
Implements #4294