Skip to content

Commit 2071bbe

Browse files
committed
fix(admin): filter by spamming is inverted
1 parent c551ad2 commit 2071bbe

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

controller/sentry/filters.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,6 @@ def queryset(self, request: "HttpRequest", queryset: "QuerySet[App]") -> "QueryS
5050
if (value := self.value()) is None:
5151
return queryset
5252

53-
event_type = EventType.FIRING if value == "no" else EventType.DISCARD
53+
event_type = EventType.DISCARD if value == "no" else EventType.FIRING
5454

5555
return queryset.filter(project__last_event__type=event_type)

controller/sentry/tests/test_admin.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -472,11 +472,11 @@ def test_app_filter(admin_with_user):
472472
assert filter_yes.lookups(request, site) == (("yes", "Yes"), ("no", "No"))
473473

474474
assert list(filter_yes.queryset(request, App.objects.all())) == list(
475-
App.objects.filter(reference=app_discard.reference)
475+
App.objects.filter(reference=app_firing.reference)
476476
)
477477

478478
assert list(filter_no.queryset(request, App.objects.all())) == list(
479-
App.objects.filter(reference=app_firing.reference)
479+
App.objects.filter(reference=app_discard.reference)
480480
)
481481

482482
assert list(filter_none.queryset(request, App.objects.all())) == list(App.objects.all())

0 commit comments

Comments
 (0)