fix: cache

use per-view cache and invalidate cache when model chnages using admin

Author: Kl0ven

config.py

@@ -4,7 +4,7 @@
 worker_class = "gevent"
 workers = int(os.getenv("WORKERS", "4"))
 bind = [
-    f'{os.environ.get("HTTP_ADDR", "0.0.0.0")}:{os.environ.get("HTTP_PORT", "8080")}'
+    f'{os.environ.get("HTTP_ADDR", "0.0.0.0")}:{os.environ.get("HTTP_PORT", "8000")}'
 ]
 daemon = os.environ.get("DEAMON_RUNNING", False)
 timeout = os.environ.get("TIMEOUT", 60)

controller/sentry/admin.py

@@ -13,6 +13,7 @@
 
 from controller.sentry.forms import BumpForm
 from controller.sentry.models import App
+from controller.sentry.utils import invalidate_cache
 
 
 @admin.register(App)
@@ -86,3 +87,7 @@ def bump(self, request, queryset, form: BumpForm = None):
             active_sample_rate=form.cleaned_data["new_sample_rate"],
             active_window_end=new_date,
         )
+
+    def save_model(self, request, obj, form, change) -> None:
+        invalidate_cache(f"/sentry/apps/{obj.reference}/")
+        return super().save_model(request, obj, form, change)

controller/sentry/utils.py

@@ -0,0 +1,39 @@
+from django.conf import settings
+from django.core.cache import cache
+from django.http import HttpRequest
+from django.utils.cache import get_cache_key
+
+
+def invalidate_cache(path=""):
+    """this function uses Django's caching function get_cache_key(). Since 1.7,
+    Django has used more variables from the request object (scheme, host,
+    path, and query string) in order to create the MD5 hashed part of the
+    cache_key. Additionally, Django will use your server's timezone and
+    language as properties as well. If internationalization is important to
+    your application, you will most likely need to adapt this function to
+    handle that appropriately.
+    """
+
+    # Bootstrap request:
+    #   request.path should point to the view endpoint you want to invalidate
+    #   request.META must include the correct SERVER_NAME and SERVER_PORT as django uses these in order
+    #   to build a MD5 hashed value for the cache_key. Similarly, we need to artificially set the
+    #   language code on the request to 'en-us' to match the initial creation of the cache_key.
+    #   YMMV regarding the language code.
+    request = HttpRequest()
+    request.META = settings.CACHE_META_INVALIDATION
+    request.LANGUAGE_CODE = "en-us"
+    request.path = path
+
+    try:
+        cache_key = get_cache_key(request)
+        if cache_key:
+            if cache_key in cache:
+                cache.delete(cache_key)
+                return (True, "successfully invalidated")
+            else:
+                return (False, "cache_key does not exist in cache")
+        else:
+            raise ValueError("failed to create cache_key")
+    except (ValueError, Exception) as e:
+        return (False, e)

controller/settings.py

@@ -50,9 +50,7 @@
 MIDDLEWARE = [
     "django.middleware.security.SecurityMiddleware",
     "django.contrib.sessions.middleware.SessionMiddleware",
-    "django.middleware.cache.UpdateCacheMiddleware",
     "django.middleware.common.CommonMiddleware",
-    "django.middleware.cache.FetchFromCacheMiddleware",
     "django.middleware.csrf.CsrfViewMiddleware",
     "django.contrib.auth.middleware.AuthenticationMiddleware",
     "django.contrib.messages.middleware.MessageMiddleware",
@@ -135,28 +133,35 @@
 
 DEFAULT_AUTO_FIELD = "django.db.models.BigAutoField"
 
+CONN_MAX_AGE = None
+APP_CACHE_TIMEOUT = 0
 
 if not DEBUG:
+    APP_CACHE_TIMEOUT = int(os.getenv("APP_CACHE_TIMEOUT", "600"))
     CACHES = {
         "default": {
             "BACKEND": "django.core.cache.backends.redis.RedisCache",
             "LOCATION": os.getenv("CACHE_REDIS_URL", "redis://127.0.0.1:6379"),
             "OPTIONS": {
-                "db": "10",
                 "parser_class": "redis.connection.PythonParser",
                 "pool_class": "redis.BlockingConnectionPool",
             },
             "TIMEOUT": int(os.getenv("CACHE_TIMEOUT", "120")),
         }
     }
 
-CONN_MAX_AGE = None
 
-APP_CACHE_TIMEOUT = int(os.getenv("APP_CACHE_TIMEOUT", "600"))
 DEFAULT_SAMPLE_RATE = float(os.getenv("DEFAULT_SAMPLE_RATE", "0.1"))
 DEFAULT_WSGI_IGNORE_PATHS = os.getenv(
     "DEFAULT_WSGI_IGNORE_PATHS", "/health,/healthz,/health/,/healthz/"
 ).split(",")
 
 
 DEFAULT_CELERY_IGNORE_TASKS = []
+
+
+CACHE_META_INVALIDATION = {
+    "SERVER_NAME": os.getenv("CACHE_META_SERVER_NAME", "localhost"),
+    "SERVER_PORT": int(os.getenv("CACHE_META_SERVER_PORT", "8000")),
+    "HTTP_ACCEPT": os.getenv("CACHE_META_HTTP_ACCEPT", "*/*"),
+}