Address errorprone warnings.

Author: yuri-sergiichuk

datastore/src/main/java/io/spine/server/storage/datastore/DsSessionStorage.java

@@ -80,8 +80,6 @@ Optional<ShardSessionRecord> read(ShardIndex index) {
      * {@inheritDoc}
      *
      * <p>Executes the write operation in a new transaction.
-     *
-     * @param message
      */
     @Override
     public void write(ShardSessionRecord message) {

datastore/src/test/java/io/spine/server/storage/datastore/DsRecordStorageTest.java

@@ -91,7 +91,6 @@
 import static io.spine.protobuf.AnyPacker.unpack;
 import static io.spine.server.ContextSpec.singleTenant;
 import static io.spine.server.entity.FieldMasks.applyMask;
-import static io.spine.server.entity.storage.EntityRecordWithColumns.create;
 import static io.spine.server.storage.datastore.given.CollegeEntity.CollegeColumn.ADMISSION_DEADLINE;
 import static io.spine.server.storage.datastore.given.CollegeEntity.CollegeColumn.CREATED;
 import static io.spine.server.storage.datastore.given.CollegeEntity.CollegeColumn.NAME;
@@ -161,7 +160,8 @@ protected EntityState newState(ProjectId projectId) {
     private EntityRecordWithColumns newRecordWithColumns(RecordStorage<ProjectId> storage) {
         EntityRecord record = newStorageRecord();
         Entity<ProjectId, Project> entity = new TestCounterEntity(newId());
-        EntityRecordWithColumns recordWithColumns = create(record, entity, storage);
+        EntityRecordWithColumns recordWithColumns =
+                EntityRecordWithColumns.create(record, entity, storage);
         return recordWithColumns;
     }
 
@@ -225,7 +225,8 @@ void testPersistColumns() {
                 .setVersion(versionValue)
                 .vBuild();
         DsRecordStorage<ProjectId> storage = newStorage(TestCounterEntity.class);
-        EntityRecordWithColumns recordWithColumns = create(record, entity, storage);
+        EntityRecordWithColumns recordWithColumns =
+                EntityRecordWithColumns.create(record, entity, storage);
         ImmutableSet<String> columns = recordWithColumns.columnNames()
                                                         .stream()
                                                         .map(ColumnName::value)
@@ -324,7 +325,8 @@ void testLifecycleFlags() {
                 .vBuild();
         TestCounterEntity entity = new TestCounterEntity(id);
         RecordStorage<ProjectId> storage = newStorage(TestCounterEntity.class);
-        EntityRecordWithColumns recordWithColumns = create(record, entity, storage);
+        EntityRecordWithColumns recordWithColumns =
+                EntityRecordWithColumns.create(record, entity, storage);
         storage.write(id, recordWithColumns);
 
         RecordReadRequest<ProjectId> request = new RecordReadRequest<>(id);
@@ -609,7 +611,10 @@ void testQueryEntityWithoutLifecycleById() {
             ProjectId id = newId();
             EntityRecord record = newEntityRecord(id, newState(id));
             EntityWithoutLifecycle entity = new EntityWithoutLifecycle(id);
-            storage.writeRecord(entity.id(), create(record, entity, storage));
+            storage.writeRecord(
+                    entity.id(),
+                    EntityRecordWithColumns.create(record, entity, storage)
+            );
 
             // Create ID filter.
             List<Any> targetIds = singletonList(pack(entity.id()));

datastore/src/test/java/io/spine/server/storage/datastore/given/DsInboxStorageTestEnv.java

@@ -76,7 +76,7 @@ public static InboxMessage generate(int shardIndex, int totalShards, Timestamp w
     }
 
     /**
-     * Generates {@code totalMessage} in a selected shard.
+     * Generates {@code totalMessages} in a selected shard.
      *
      * <p>Each message is generated as received {@code now} and in
      * {@link InboxMessageStatus#TO_DELIVER TO_DELIVER} status.

datastore/src/test/java/io/spine/server/storage/datastore/given/DsRecordStorageTestEnv.java

@@ -56,7 +56,6 @@
 import static io.spine.client.OrderBy.Direction.DESCENDING;
 import static io.spine.protobuf.AnyPacker.pack;
 import static io.spine.protobuf.AnyPacker.unpack;
-import static io.spine.server.entity.storage.EntityRecordWithColumns.create;
 import static java.util.Collections.shuffle;
 import static java.util.Collections.unmodifiableList;
 import static java.util.Comparator.comparing;
@@ -245,18 +244,19 @@ private static CollegeEntity createAndStoreEntity(RecordStorage<CollegeId> stora
         return entity;
     }
 
-    private static CollegeEntity createAndStoreEntity(RecordStorage<CollegeId> storage,
-                                                      String name) {
+    private static CollegeEntity
+    createAndStoreEntity(RecordStorage<CollegeId> storage, String name) {
         CollegeId id = newCollegeId();
         College state = newCollege(id, name);
         CollegeEntity entity = CollegeEntity.create(id, state);
         storeEntity(storage, entity);
         return entity;
     }
 
-    public static void storeEntity(RecordStorage<CollegeId> storage, CollegeEntity entity) {
+    private static void storeEntity(RecordStorage<CollegeId> storage, CollegeEntity entity) {
         EntityRecord record = newEntityRecord(entity.id(), entity.state());
-        EntityRecordWithColumns withColumns = create(record, entity, storage);
+        EntityRecordWithColumns withColumns =
+                EntityRecordWithColumns.create(record, entity, storage);
         storage.write(entity.id(), withColumns);
     }